From owner-freebsd-gnome@FreeBSD.ORG Fri Jul 27 16:04:56 2012 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 740FD106564A; Fri, 27 Jul 2012 16:04:56 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from megatron.madpilot.net (megatron.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id 0F3F68FC0C; Fri, 27 Jul 2012 16:04:56 +0000 (UTC) Received: from megatron.madpilot.net (localhost [127.0.0.1]) by megatron.madpilot.net (Postfix) with ESMTP id 3WkFPM2JXHz2h1; Fri, 27 Jul 2012 18:04:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received; s=mail; t=1343405092; x= 1345219493; bh=BCkE+FwT/r2CiznLxtQj9iIV7hVQiPM+941dWtIjxlU=; b=o C6bUtLXZEo3v9KsBQdBtqXTOrDNhxncEZmT5RHEwnY/AfyoPvSEAoqQ09/e3GXsm VAc9NGfATnQ6kgXakMAYYVCPSS27OlF7qaMFaiwQqE+a+coso6fvirw983Tw8vTx w80AXEV7qKwep5TpodcKURQAS1ECPVH3R5yY8U1zbI= X-Virus-Scanned: amavisd-new at madpilot.net Received: from megatron.madpilot.net ([127.0.0.1]) by megatron.madpilot.net (megatron.madpilot.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4SrDHcjgAAMv; Fri, 27 Jul 2012 18:04:52 +0200 (CEST) Received: by megatron.madpilot.net (Postfix, from userid 1000) id 3WkFPJ6KT3z2h0; Fri, 27 Jul 2012 18:04:52 +0200 (CEST) Date: Fri, 27 Jul 2012 18:04:52 +0200 From: Guido Falsi To: Jeremy Messenger Message-ID: <20120727160452.GF22954@megatron.madpilot.net> References: <20120727153119.GE22954@megatron.madpilot.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 9.0-STABLE User-Agent: Mutt/1.5.21 (2010-09-15) Cc: gnome@freebsd.org, Chris Rees , Thomas Abthorpe Subject: Re: [PATCH] Gnucash port update and fix for pkgconf X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2012 16:04:56 -0000 On Fri, Jul 27, 2012 at 10:50:40AM -0500, Jeremy Messenger wrote: > On Fri, Jul 27, 2012 at 10:31 AM, Guido Falsi wrote: > > Hi! > > > > The finance/gnucash port is broken right now. > > > > It contains an improper use of pkg-config which was innocuous, but is > > fatal with pkgconf. It causes an invalid Makefile to be generated by > > configure. > > > > Since a new version is also out I made a patch with a quick and dirty > > fix for the brokenness. > > > > The fix just forces a bogus value in the configure script in place of a > > backtick comamnd. That variable really looks unused anyway by the build > > system. GnuCash builds fine in tinderbox and wiorks correctly on a real > > system with real data. > > > > I'm attaching it requesting approval to commit it. > > > > I also wrote a bug report for this on the gnome bugzilla, waiting > > feedback. ( https://bugzilla.gnome.org/show_bug.cgi?id=680708 ) > > You have my approval. Yes, it does look like it's just some leftover > and need to be removed. Just let you know about --version can be > changed to --modversion if you find other ports that have like this. > Thanks! > > $PKG_CONFIG --version xml > > To: > > $PKG_CONFIG --modversion libxml-2.0 This is good to know! Thanks! Also the bug I filed had a very fast turnover and the removal of that variable has already been committed to their tree. So this will be a temporary fix till the next update, I hope. -- Guido Falsi