From owner-svn-ports-all@freebsd.org Tue Dec 8 16:44:47 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20D184A6226; Tue, 8 Dec 2020 16:44:47 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cr5cv0DB8z4dC9; Tue, 8 Dec 2020 16:44:46 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-qt1-x82c.google.com with SMTP id h19so10100353qtq.13; Tue, 08 Dec 2020 08:44:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=9iXSkuxjby/HDqA39nRlpHbgeoAyt2Ps8V++L/BZrso=; b=NsUmU9uPoVCvNpMKAlnVsmzEkGnaQAUNUqOJmYJmou2CDALqcaYlRbzMCbWT9gDym9 CNb0wS/+KWjDcGpRi+tOx/vRexv+DQktBGO9gJGHYN8eFu2/pNhP0F/SBFS4b77w8N2U c+B/bC8klvp4dXJSkMiDb2AsKxn3jzVqM6JbKyhOuA7lMiNTNh6+fzHxkOcM7vdKTiI/ wKDxm48dBw+5qpH4A0g2cw3TL0HKqI0ulEhAnivVC67FggjzONAadbBPrXq33IyhME0z 7K4CezqVqomM+Klu1X8Zdc1gNEi8mByUTxjf8Chd2ZIekbLh2AM7RjaNWD6Z1z8m1PNz iemg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9iXSkuxjby/HDqA39nRlpHbgeoAyt2Ps8V++L/BZrso=; b=DgFhIu6spYgV8f3uwmLublDE6yFnVDeBNeYNapSYi4GK8HvNAI6SLDD1hfKk+RIVXf Aut304vvg14MdyfaqYA8rsVIpU0xjYW78i7LOs03MPPKSL+AAZjrZWh05FNEk+CvQMEE IMV1l37VTsXj5fSqYSZiiwmZlzPGvT04aERBHPSwsEMBLqNrz4wqSE5hJTu6LyophkFO k9jRjc2k5k+gOWtki3kO1doXDdb2sDN1gNDrRCHgeCfyUKlSywpQ9Vw/RvjkwHX8Z4qZ m4eSBQ5p8IvPjk1O+N4HBAx4/BZP5V4keZkc5dwedg48+3mviwRD//bk2TSikub1TSba RF/g== X-Gm-Message-State: AOAM5301svA3kmGJBxP4aYXU/38Jnuf/I/DyrgdjzqTOkRqnH1MKFicu X4iROYjTgpKscAX+GGC7DdJt6ll/8iM= X-Google-Smtp-Source: ABdhPJw84TWkkEfIVnquhW0IjBMJClcUNVlvmyYM7wMZjoArPbQxD+/hJCrh5rZ9kgezx9T3atrTIg== X-Received: by 2002:a05:622a:30e:: with SMTP id q14mr31682769qtw.77.1607445885823; Tue, 08 Dec 2020 08:44:45 -0800 (PST) Received: from orca.acadix.biz (2603-6000-a401-3a00-0224-d2ff-fe27-bb80.res6.spectrum.com. [2603:6000:a401:3a00:224:d2ff:fe27:bb80]) by smtp.gmail.com with ESMTPSA id n2sm2060224qkf.37.2020.12.08.08.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Dec 2020 08:44:45 -0800 (PST) Subject: Re: svn commit: r557295 - in head/sysutils/slurm-wlm: . files To: Kyle Evans , "Jason W. Bacon" Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202012081621.0B8GLGu7011665@repo.freebsd.org> From: Jason Bacon Message-ID: Date: Tue, 8 Dec 2020 10:44:44 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 4Cr5cv0DB8z4dC9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 16:44:47 -0000 On 12/8/20 10:28 AM, Kyle Evans wrote: > On Tue, Dec 8, 2020 at 10:21 AM Jason W. Bacon wrote:= >> Author: jwb >> Date: Tue Dec 8 16:21:16 2020 >> New Revision: 557295 >> URL: https://svnweb.freebsd.org/changeset/ports/557295 >> >> Log: >> sysutils/slurm-wlm: Back out -fno-common patches, add -fcommon flag= >> >> Fixes runtime regression caused by r546150 >> >> Reported by: jrm >> MFH: 2020Q4 >> > I guess the regression was from the patch to > src/plugins/select/cons_tres/job_test.c and an issue somewhere without > slurmctld? That patch almost certainly should have made them weak > references instead of removing them entirely, based on the comment in > the vicinity. > > Thanks, > > Kyle Evans It's more complicated than that.=C2=A0 I tried converting to weak refs, b= ut=20 the files are linked into multiple executables + the use of dlopen might = obscure things to the compiler/linker.=C2=A0 I'd have to review the rules= to=20 verify the latter. I'll see if upstream has made -fcommon unnecessary in the next release=20 when I have time to work on an upgrade a few weeks out. Best, =C2=A0=C2=A0=C2=A0 JB --=20 Earth is a beta site.