Date: Fri, 07 Jan 2011 18:05:16 +0300 From: Anonymous <swell.k@gmail.com> To: Konstantin Belousov <kib@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217101 - head/lib/libcompiler_rt Message-ID: <8662u0ycsz.fsf@gmail.com> In-Reply-To: <201101071435.p07EZkNU055560__46495.048949919$1294410977$gmane$org@svn.freebsd.org> (Konstantin Belousov's message of "Fri, 7 Jan 2011 14:35:46 %2B0000 (UTC)") References: <201101071435.p07EZkNU055560__46495.048949919$1294410977$gmane$org@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Konstantin Belousov <kib@FreeBSD.org> writes: > Author: kib > Date: Fri Jan 7 14:35:45 2011 > New Revision: 217101 > URL: http://svn.freebsd.org/changeset/base/217101 > > Log: > On amd64 and i386, force assembler to mark objects compiled from the > assembler source for libcompiler_rt as not needed executable stack. This > is done with a hammer instead of properly marking each assembly file > with section .note.GNU-stack to avoid modifying contributed source. > > Discussed with: ed > > Modified: > head/lib/libcompiler_rt/Makefile > > Modified: head/lib/libcompiler_rt/Makefile > ============================================================================== > --- head/lib/libcompiler_rt/Makefile Fri Jan 7 14:32:29 2011 (r217100) > +++ head/lib/libcompiler_rt/Makefile Fri Jan 7 14:35:45 2011 (r217101) > @@ -156,4 +156,10 @@ SYMLINKS+=libcompiler_rt_p.a ${LIBDIR}/l > . endif > .endif > > +.if ${MACHINE_CPUARCH} == "amd64" || ${MACHINE_CPUARCH} == "i386" > +AFLAGS+=--noexecstack > +ACFLAGS+=-Wl,a,--noexecstack > +.endif Typo? -Wl,a,--foo vs. -Wa,--foo. From gcc(1) manpage Assembler Option -Wa,option -Xassembler option Linker Options -Wl,option -Xlinker option
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8662u0ycsz.fsf>