From owner-freebsd-stable@freebsd.org Thu Mar 5 12:55:13 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AD6A8268C07 for ; Thu, 5 Mar 2020 12:55:13 +0000 (UTC) (envelope-from trond.endrestol@ximalas.info) Received: from enterprise.ximalas.info (enterprise.ximalas.info [IPv6:2001:700:1100:1::8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "ximalas.info", Issuer "Hostmaster ximalas.info" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Y9hH4xFmz419r; Thu, 5 Mar 2020 12:55:11 +0000 (UTC) (envelope-from trond.endrestol@ximalas.info) Received: from enterprise.ximalas.info (Ximalas@localhost [127.0.0.1]) by enterprise.ximalas.info (8.15.2/8.15.2) with ESMTPS id 025CswPd088145 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 5 Mar 2020 13:54:58 +0100 (CET) (envelope-from trond.endrestol@ximalas.info) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ximalas.info; s=default; t=1583412898; bh=Hs7LZGQa2Gt9wWkjc5J+wZRXZd5BGAHGkXrCf6DnxkY=; h=Date:From:To:cc:Subject; b=A/W1TUMfxLmThaREBFxN0FnYpbJluZFKon6H1Bt8eRzqVdLwqzMxciIMk6qDxkxg2 1PmZFo56xYfrk39UWOrMm/zr7ys+95IveAbFezwH64jmERrcAJIGiV6nVso9p/xwLe F8yXVpCMWqICYCjlJmCgFAhHp2PaYJlckElKeKjbA8bQhU9On1+2OoVUk05OhbAbV0 wsgpbneadKoegma8ntPva7tlkSxI0UVLs3dBgvVSpmhhJDSxAzsBioRTg4UfMVN8oK u+oavnTWiqD7DEU8DbUGdvrSdX6RgMpHXRyPFnx8tH3OKaRTGC2s53A2tYmsRnlqMz CRduCiEwF1Ttw== Received: from localhost (trond@localhost) by enterprise.ximalas.info (8.15.2/8.15.2/Submit) with ESMTP id 025Csw7Z088142; Thu, 5 Mar 2020 13:54:58 +0100 (CET) (envelope-from trond.endrestol@ximalas.info) X-Authentication-Warning: enterprise.ximalas.info: trond owned process doing -bs Date: Thu, 5 Mar 2020 13:54:58 +0100 (CET) From: =?UTF-8?Q?Trond_Endrest=C3=B8l?= Sender: Trond.Endrestol@ximalas.info To: freebsd-stable@freebsd.org cc: imp@freebsd.org Subject: r358661 breaks /usr/src/usr.sbin/amd/include/newvers.sh on stable/12 Message-ID: User-Agent: Alpine 2.22 (BSF 395 2020-01-19) OpenPGP: url=http://ximalas.info/about/tronds-openpgp-public-key MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on enterprise.ximalas.info X-Rspamd-Queue-Id: 48Y9hH4xFmz419r X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ximalas.info header.s=default header.b=A/W1TUMf; dmarc=pass (policy=none) header.from=ximalas.info; spf=pass (mx1.freebsd.org: domain of trond.endrestol@ximalas.info designates 2001:700:1100:1::8 as permitted sender) smtp.mailfrom=trond.endrestol@ximalas.info X-Spamd-Result: default: False [-5.08 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.983,0]; R_DKIM_ALLOW(-0.20)[ximalas.info:s=default]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[ximalas.info:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[ximalas.info,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:224, ipnet:2001:700::/32, country:NO]; IP_SCORE(-2.09)[ip: (-8.26), ipnet: 2001:700::/32(-1.43), asn: 224(-0.77), country: NO(-0.01)] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2020 12:55:13 -0000 The command "sh /usr/src/usr.sbin/amd/include/newvers.sh /usr/src/sys/conf/newvers.sh" is run a part of a normal build, creating config_local.h. After r358661, I find this in my build logs for stable/12: eval: 1: Syntax error: end of file unexpected (expecting ")") eval: 1: Syntax error: Error in command substitution Meta mode is activated, and the build logs gives this insight: _ERROR_CMD='@rm -f config_local.h; sh /usr/src/usr.sbin/amd/include/newvers.sh /usr/src/sys/conf/newvers.sh > config_local.h;' .CURDIR='/usr/src/usr.sbin/amd/include' Any attempts to build again, results in: --- amd.o --- /usr/src/contrib/amd/amd/amd.c:275:17: error: use of undeclared identifier 'HOST_OS_NAME' gopt.op_sys = HOST_OS_NAME; ^ /usr/src/contrib/amd/amd/amd.c:278:21: error: use of undeclared identifier 'HOST_OS_VERSION' gopt.op_sys_ver = HOST_OS_VERSION; ^ /usr/src/contrib/amd/amd/amd.c:281:22: error: use of undeclared identifier 'HOST_OS' gopt.op_sys_full = HOST_OS; ^ 3 errors generated. CC-ing imp@ as he's the author of r358661. -- Trond.