Date: Wed, 13 Dec 2017 11:15:54 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 210537] [patch] [feature request] set MIME type in cron-generated e-mails Message-ID: <bug-210537-8-lh1Yev81S2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210537-8@https.bugs.freebsd.org/bugzilla/> References: <bug-210537-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210537 Eugene Grosbein <eugen@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #16 from Eugene Grosbein <eugen@freebsd.org> --- (In reply to Mikhail T. from comment #15) It still does not respect WITHOUT_FILE. And if such code uses openssl, it should depend on WITHOUT_OPENSSL too. However, our libc actually has b64_ntop() function for base64 encoding prov= ided with <resolv.h> header and you can get example of its usage from src/usr.bin/uuencode/uuencode.c "usage" message mistakenly shows "-m" instead of "-M". Added #include's should be sorted by name of header. sizeof(char) is 1 by definition of C programming language (see http://chimera.roma1.infn.it/SP/COMMON/iso-iec-9899-1990.pdf section 6.5.3.4 paragraph 4), so you need not use bufsize*sizeof(char). With MAGIC_MIME flag to magic_open() you request both of MIME type and enco= ding but then skip MIME type with strstr() looking for encoding only. Wouldn't it better to use MAGIC_MIME_ENCODING instead of MAGIC_MIME and directly compare result with "charset=3Dbinary"? Otherwise, looks good, thanks! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210537-8-lh1Yev81S2>