From owner-svn-src-head@freebsd.org Sat Aug 22 22:34:52 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB06F9BF464; Sat, 22 Aug 2015 22:34:52 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: from mail-la0-x22e.google.com (mail-la0-x22e.google.com [IPv6:2a00:1450:4010:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 71DB56C1; Sat, 22 Aug 2015 22:34:52 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: by laba3 with SMTP id a3so58782306lab.1; Sat, 22 Aug 2015 15:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=xPCFxGcScqe+G6TIfhFfYq2OdFTdKRbr0oL2OMOMed8=; b=yx2wy/41lB58oOvEgv0rUdtwuX7Lt8Bnc41g4dd1qQrEEUJL3U+dFXwAoFZ0C/Ul/2 A1z/ESzki7MXp1PwjqzzLhH3BGFP2kn9Q5CA6z6zPfuz06eMbSf2YXI4HSJHx9usRg0x nbAqhw8+uHIMrzFLx/4RalavnW7bd9QsdvknreCskbAGsi8/ylOjiO52bN7YqCePuTqo by+bek5z43GrFbN94+ZVwH7qWrm5qxYSaJAfXeahsF2VfXPXHTd0zGeglx+rUkSLVa3Z OwJ0NeGsWhfHCIJLpXvBRX6Del5F94zYQqz1t7imdfXtxeDYoElwaHGwNDe1LRoYDdMl vohg== MIME-Version: 1.0 X-Received: by 10.112.167.202 with SMTP id zq10mr13737179lbb.69.1440282889473; Sat, 22 Aug 2015 15:34:49 -0700 (PDT) Received: by 10.112.12.234 with HTTP; Sat, 22 Aug 2015 15:34:49 -0700 (PDT) In-Reply-To: References: <201508212202.t7LM2MhF015522@repo.freebsd.org> Date: Sat, 22 Aug 2015 19:34:49 -0300 Message-ID: Subject: Re: svn commit: r287009 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf From: Luiz Otavio O Souza To: =?UTF-8?Q?Ermal_Lu=C3=A7i?= Cc: Luiz Otavio O Souza , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2015 22:34:53 -0000 On Sat, Aug 22, 2015 at 6:18 AM, Ermal Lu=C3=A7i wrote: > > > On Sat, Aug 22, 2015 at 12:02 AM, Luiz Otavio O Souza > wrote: >> >> Author: loos >> Date: Fri Aug 21 22:02:22 2015 >> New Revision: 287009 >> URL: https://svnweb.freebsd.org/changeset/base/287009 >> >> Log: >> Add ALTQ(9) support for the CoDel algorithm. >> >> CoDel is a parameterless queue discipline that handles variable >> bandwidth >> and RTT. >> >> It can be used as the single queue discipline on an interface or as a >> sub >> discipline of existing queue disciplines such as PRIQ, CBQ, HFSC, FAIR= Q. >> >> Differential Revision: https://reviews.freebsd.org/D3272 >> Reviewd by: rpaulo, gnn (previous version) > > > I thought part of this commit message was taken from me as a reviewer, no= ? Sorry Ermal, my bad. As you only commented and not accepted the review I thought you don't want to be implied with a reviewed by. [...] >> Added: head/sys/net/altq/altq_codel.c >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/sys/net/altq/altq_codel.c Fri Aug 21 22:02:22 2015 >> (r287009) >> @@ -0,0 +1,477 @@ >> +/* >> + * CoDel - The Controlled-Delay Active Queue Management algorithm >> + * >> + * Copyright (C) 2013 Ermal Luci > > > Can you correct my name? > Sure, I'll commit the fix soon (probably on monday) I'm AFK this weekend. I really appreciate your work on Codel. Regards, Luiz