From owner-svn-ports-head@FreeBSD.ORG Tue Jun 11 16:34:07 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E87F32C9 for ; Tue, 11 Jun 2013 16:34:07 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) by mx1.freebsd.org (Postfix) with ESMTP id C291D1D40 for ; Tue, 11 Jun 2013 16:34:07 +0000 (UTC) Received: by mail-pa0-f49.google.com with SMTP id ld11so2806624pab.22 for ; Tue, 11 Jun 2013 09:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=TM0m7xiz1yK1KoKjKwrIMutcAWCaPBMhWUP4MkIFtPU=; b=I/PUDE0BzJEOvbQjJrH0BVY6p/YT+rLrvLRtP2FPwroQ2scn84yP8Jy5jtNvr4ECHD KF7rD1LZELt2iX5Oc7dXUqX2A0lVfNtuim5gxkWLczWRGIjyzOeELZ47hG1gdRPk9IYk Vwf2pWGGqP+JFOOSzMyEfQW99A9lTKcIJcKyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=TM0m7xiz1yK1KoKjKwrIMutcAWCaPBMhWUP4MkIFtPU=; b=iT6ufGyJYn6urJQU2skc2IFzM25apvpvswVQa7zaX+O7k/axB9ayru7oHxptLz1TQe Mfm+GrwaDw7tmoJe5cIbvH/tflXMggeX737WvEhY6qUjNyystAMPvLxIs0B7fx6D7vho 0uIMVBkVZkhfQa/fwnkXTXPeun9loac5gYZQxH3JR2mrv7JSdbbnKLwGWfp8Nuy3ieo1 NBMgdP8sN6IuqWY49JpBoSsvix659vGUkUoRNQd+BUDjHu0umF0OY8H0EHfky+gmOuUd vFZ4cTjjtpdViV3woyn3wF4tAq58waXIYMegrMnZxNYWa5GmkDh+do4jnX7jYOI5E7i7 aemQ== X-Received: by 10.66.227.38 with SMTP id rx6mr19247421pac.195.1370968447477; Tue, 11 Jun 2013 09:34:07 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.70.45.33 with HTTP; Tue, 11 Jun 2013 09:33:37 -0700 (PDT) In-Reply-To: <201306111055.r5BAtHmb094470@svn.freebsd.org> References: <201306111055.r5BAtHmb094470@svn.freebsd.org> From: Eitan Adler Date: Tue, 11 Jun 2013 18:33:37 +0200 X-Google-Sender-Auth: OwGjx6jPGshZlEiyjLGJCx4ws50 Message-ID: Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkjzWhdr0alfC4MarohIoOTj0svqA/1CaMTWVAvecUa0MMg8oiAGNZ7x5MmTQL1tr8TLUgX Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jun 2013 16:34:08 -0000 On Tue, Jun 11, 2013 at 12:55 PM, Baptiste Daroussin wrote: > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/tradcpp/files/patch-directive.c Tue Jun 11 10:55:16 2013 (r320546) > + static > + void > +-d_line(struct place *p, struct place *p2, char *line) > ++d_line(struct place *p, struct place *p2 __unused, char *line __unused) ... > +-d_pragma(struct place *p, struct place *p2, char *line) > ++d_pragma(struct place *p, struct place *p2 __unused, char *line) ... > +-filter_output(const struct place *p, const char *buf, size_t len) > ++filter_output(const struct place *p __unused, const char *buf, size_t len) Perhaps we could build without warnings instead of patching the source? this would simplify the port and make it more obvious what is being solved. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams