Date: Tue, 11 Jun 2013 18:33:37 +0200 From: Eitan Adler <eadler@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files Message-ID: <CAF6rxg=iqSGrFK3Ug0Hzh6nRGnzUA5-Ug_aXrGs4xybBPAty3A@mail.gmail.com> In-Reply-To: <201306111055.r5BAtHmb094470@svn.freebsd.org> References: <201306111055.r5BAtHmb094470@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 11, 2013 at 12:55 PM, Baptiste Daroussin <bapt@freebsd.org> wrote: > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/tradcpp/files/patch-directive.c Tue Jun 11 10:55:16 2013 (r320546) > + static > + void > +-d_line(struct place *p, struct place *p2, char *line) > ++d_line(struct place *p, struct place *p2 __unused, char *line __unused) ... > +-d_pragma(struct place *p, struct place *p2, char *line) > ++d_pragma(struct place *p, struct place *p2 __unused, char *line) ... > +-filter_output(const struct place *p, const char *buf, size_t len) > ++filter_output(const struct place *p __unused, const char *buf, size_t len) Perhaps we could build without warnings instead of patching the source? this would simplify the port and make it more obvious what is being solved. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=iqSGrFK3Ug0Hzh6nRGnzUA5-Ug_aXrGs4xybBPAty3A>