From owner-freebsd-ports Sat Oct 27 18:50:57 2001 Delivered-To: freebsd-ports@freebsd.org Received: from smtp.noos.fr (zola.noos.net [212.198.2.76]) by hub.freebsd.org (Postfix) with ESMTP id A37C437B405 for ; Sat, 27 Oct 2001 18:50:54 -0700 (PDT) Received: (qmail 10775993 invoked by uid 0); 28 Oct 2001 01:50:53 -0000 Received: from unknown (HELO gits.dyndns.org) ([212.198.229.145]) (envelope-sender ) by 212.198.2.76 (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 28 Oct 2001 01:50:53 -0000 Received: (from root@localhost) by gits.dyndns.org (8.11.6/8.11.6) id f9S1oq188022; Sun, 28 Oct 2001 02:50:52 +0100 (CET) (envelope-from root) Message-Id: <200110280150.f9S1oq188022@gits.dyndns.org> Subject: Re: ports/29858: Updated port: audio/lame (3.89b) In-Reply-To: <200110271014.f9RAE9B87688@freefall.freebsd.org> To: kuriyama@FreeBSD.org Date: Sun, 28 Oct 2001 02:50:52 +0100 (CET) Cc: freebsd-ports@FreeBSD.org Reply-To: clefevre@citeweb.net From: Cyrille Lefevre Organization: ACME X-Face: X-Mailer: ELM [version 2.4ME+ PL94c (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org kuriyama@FreeBSD.org wrote: > State-Changed-From-To: open->closed [snip] > After talking with Yoshiaki Uchikawa, I decided to commit this PR as > lame-devel port. This port will be obsoleted and audio/lame will be > updated if this version become to see stable. > > I assign you as maintainer of this port. I modified a little in Makefile > from your PR. So please re-submit PR you want more modification to this > port. before to submit a new PR, let me ask you some questions : why did you get rid of PKGNAMESUFFIX=-devel and INSTALLS_SHLIB=yes ? PKGNAMESUFFIX=-devel make this port distinct from the original one and avoid namespace conflict when `pkg_add -r lame' is used. are you sure INSTALLS_SHLIB isn't needed ? my understanding of this variable is that it is required when ports install shared libraries. Cyrille. -- Cyrille Lefevre mailto:clefevre@citeweb.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message