Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Jan 2007 17:28:47 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Scott Long <scottl@samsco.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger <netchild@FreeBSD.org>, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/compat/linprocfs linprocfs.c
Message-ID:  <20070121162847.GA19379@garage.freebsd.pl>
In-Reply-To: <45B271AD.9000503@samsco.org>
References:  <200701201932.l0KJWNST091647@repoman.freebsd.org> <45B271AD.9000503@samsco.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 20, 2007 at 12:46:53PM -0700, Scott Long wrote:
> Alexander Leidinger wrote:
> >netchild    2007-01-20 19:32:23 UTC
> >  FreeBSD src repository
> >  Modified files:
> >    sys/compat/linprocfs linprocfs.c   Log:
> >  Fix tinderbox build on amd64.
> >    Revision  Changes    Path
> >  1.104     +2 -2      src/sys/compat/linprocfs/linprocfs.c
>=20
> Try the following instead:
>=20
> --- linprocfs.c 20 Jan 2007 19:32:23 -0000      1.104
> +++ linprocfs.c 20 Jan 2007 19:46:29 -0000
> @@ -474,8 +474,8 @@
>                 state =3D 'R';
>=20
>                 if (ratelimit =3D=3D 0) {
> -                       printf("linprocfs: don't know how to handle unkno=
wn FreeBSD state %d/%jd, mapping to R\n",
> -                           kp.ki_stat, (intmax_t)sizeof(linux_state));
> +                       printf("linprocfs: don't know how to handle unkno=
wn FreeBSD state %d/%zd, mapping to R\n",
> +                           kp.ki_stat, sizeof(linux_state));

AFAIK sizeof() returns size_t, which is unsigned, so %zu should be used.
%zd is used for ssize_t.

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--ZGiS0Q5IWpPtfppv
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFFs5S/ForvXbEpPzQRAgd1AJ4xhDSVewOS4K0ebV/Ouzg9AZaaZgCfQRaK
rT+3Mxo1Q6vAtn31j29mTpM=
=QvAQ
-----END PGP SIGNATURE-----

--ZGiS0Q5IWpPtfppv--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070121162847.GA19379>