From owner-freebsd-ports Fri Mar 23 10:37:14 2001 Delivered-To: freebsd-ports@freebsd.org Received: from isris.pair.com (isris.pair.com [209.68.2.39]) by hub.freebsd.org (Postfix) with SMTP id 18A5837B71B for ; Fri, 23 Mar 2001 10:37:11 -0800 (PST) (envelope-from rooneg@isris.pair.com) Received: (qmail 30058 invoked by uid 3130); 23 Mar 2001 18:37:10 -0000 Date: Fri, 23 Mar 2001 13:37:10 -0500 From: Garrett Rooney To: Maxim Sobolev Cc: ports@FreeBSD.org, jhk@FreeBSD.org, gad@FreeBSD.org Subject: Re: [patch] which package functionality for pkg_info Message-ID: <20010323133710.B26933@electricjellyfish.net> References: <20010301145950.B90945@electricjellyfish.net> <200103012014.f21KESc59992@vic.sabbo.net> <20010322183141.B23846@electricjellyfish.net> <3ABB17E8.A5558BDD@FreeBSD.org> <3ABB9565.F5F0C22@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3ABB9565.F5F0C22@FreeBSD.org>; from sobomax@FreeBSD.org on Fri, Mar 23, 2001 at 08:26:45PM +0200 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, Mar 23, 2001 at 08:26:45PM +0200, Maxim Sobolev wrote: > Maxim Sobolev wrote: > > Thank you for your reminder. I have several other comments regarding your > > patchset, which I hopefully will submit to you later today. Please hold on. > > Ok with this message I'm attaching final version of the patch in question. > Following fixes/cleanups have been made: > - comments formatted to match style(9); > - popen(3) return value check added; > - cmp_path() function simplified; > - error messages slighly ajusted to follow usual format; > - includes reordered to be consistent across the source; > - etc. > > If you agree with this patch, please let me know and I'll commit it shortly. These all seem fine with me. I especially like the change to cmp_path, as that is quite a bit simpler than my version. I'll have to remember that one. -- garrett rooney Unix was not designed to stop you from rooneg@electricjellyfish.net doing stupid things, because that would http://electricjellyfish.net/ stop you from doing clever things. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message