Date: Mon, 1 May 2006 01:27:37 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: =?ISO-8859-1?Q?Mikko_Ty=F6l=E4j=E4rvi?= <mbsd@pacbell.net> Cc: mobile@freebsd.org Subject: Re: if_bfe and > 1 GB of ram is now fixed (fwd) Message-ID: <20060501012306.G731@odysseus.silby.com> In-Reply-To: <20060430151724.N4092@antec.home> References: <20060429102214.V9858@odysseus.silby.com> <20060430134609.U4092@antec.home> <20060430163316.B724@odysseus.silby.com> <20060430151724.N4092@antec.home>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-125664624-1146464857=:731 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Sun, 30 Apr 2006, Mikko Ty=F6l=E4j=E4rvi wrote: > Verfied that limiting RAM still works. I guess the code path that > needs the locking isn't being triggered, as it seems to deal with > bounce buffers. > > Actually, even with 2G I can get an address via DHCP, do DNS lookups, > ping some hosts and even have a short telnet session without problems. > > But starting a web browser or running cvsup instantly results in the > above panic. > > /Mikko Ok, I talked to Scott Long about the problem and he explained to me why=20 it's happening. Subsequently, I was able to cause it to happen to me if I= =20 told the system that my bfe card could only accept buffers from under the= =20 128MB mark. Basically, what's happening is that there are not enough bounce buffers to= =20 go around, but the driver is assuming that there are - so when we hit the= =20 limit, it doesn't handle the error properly, and it panics. Attached is my WIP patch - it stops the panics, but acts flakey at times -= =20 in other words, it needs more work. I don't think I'll have a chance to=20 get back to it until Thursday. In the meantime, see if it helps you at=20 all. Mike "Silby" Silbersack --0-125664624-1146464857=:731 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=if_bfe.c.wip1.patch Content-Transfer-Encoding: BASE64 Content-ID: <20060501012737.T731@odysseus.silby.com> Content-Description: Content-Disposition: attachment; filename=if_bfe.c.wip1.patch LS0tIGlmX2JmZS5jCU1vbiBNYXkgIDEgMDE6MjA6MDUgMjAwNg0KKysrIGlm X2JmZS5jLndpcAlNb24gTWF5ICAxIDAxOjIwOjAwIDIwMDYNCkBAIC0yOTcs NyArMjk4LDcgQEANCiAJYnplcm8oc2MtPmJmZV9yeF9saXN0LCBCRkVfUlhf TElTVF9TSVpFKTsNCiAJZXJyb3IgPSBidXNfZG1hbWFwX2xvYWQoc2MtPmJm ZV9yeF90YWcsIHNjLT5iZmVfcnhfbWFwLA0KIAkJCXNjLT5iZmVfcnhfbGlz dCwgc2l6ZW9mKHN0cnVjdCBiZmVfZGVzYyksDQotCQkJYmZlX2RtYV9tYXAs ICZzYy0+YmZlX3J4X2RtYSwgMCk7DQorCQkJYmZlX2RtYV9tYXAsICZzYy0+ YmZlX3J4X2RtYSwgQlVTX0RNQV9OT1dBSVQpOw0KIA0KIAlpZihlcnJvcikN CiAJCXJldHVybiAoRU5PTUVNKTsNCkBAIC0zMTIsNyArMzEzLDcgQEANCiAN CiAJZXJyb3IgPSBidXNfZG1hbWFwX2xvYWQoc2MtPmJmZV90eF90YWcsIHNj LT5iZmVfdHhfbWFwLA0KIAkJCXNjLT5iZmVfdHhfbGlzdCwgc2l6ZW9mKHN0 cnVjdCBiZmVfZGVzYyksDQotCQkJYmZlX2RtYV9tYXAsICZzYy0+YmZlX3R4 X2RtYSwgMCk7DQorCQkJYmZlX2RtYV9tYXAsICZzYy0+YmZlX3R4X2RtYSwg QlVTX0RNQV9OT1dBSVQpOw0KIAlpZihlcnJvcikNCiAJCXJldHVybiAoRU5P TUVNKTsNCiANCkBAIC01NzQsNiArNTc1LDcgQEANCiAJc3RydWN0IGJmZV9k ZXNjICpkOw0KIAlzdHJ1Y3QgYmZlX2RhdGEgKnI7DQogCXVfaW50MzJfdCBj dHJsOw0KKwlpbnQgZXJyb3I7DQogDQogCWlmICgoYyA8IDApIHx8IChjID49 IEJGRV9SWF9MSVNUX0NOVCkpDQogCQlyZXR1cm4gKEVJTlZBTCk7DQpAQCAt NTk1LDggKzU5NywxMCBAQA0KIAlzYy0+YmZlX3J4X2NudCA9IGM7DQogCWQg PSAmc2MtPmJmZV9yeF9saXN0W2NdOw0KIAlyID0gJnNjLT5iZmVfcnhfcmlu Z1tjXTsNCi0JYnVzX2RtYW1hcF9sb2FkKHNjLT5iZmVfdGFnLCByLT5iZmVf bWFwLCBtdG9kKG0sIHZvaWQgKiksDQotCQkJTUNMQllURVMsIGJmZV9kbWFf bWFwX2Rlc2MsIGQsIDApOw0KKwllcnJvciA9IGJ1c19kbWFtYXBfbG9hZChz Yy0+YmZlX3RhZywgci0+YmZlX21hcCwgbXRvZChtLCB2b2lkICopLA0KKwkJ CU1DTEJZVEVTLCBiZmVfZG1hX21hcF9kZXNjLCBkLCBCVVNfRE1BX05PV0FJ VCk7DQorCWlmIChlcnJvcikNCisJCXByaW50ZigiRXJyb3IgSSBjYW4ndCBo YW5kbGUhISFcbiIpOw0KIAlidXNfZG1hbWFwX3N5bmMoc2MtPmJmZV90YWcs IHItPmJmZV9tYXAsIEJVU19ETUFTWU5DX1BSRVdSSVRFKTsNCiANCiAJY3Ry bCA9IEVUSEVSX01BWF9MRU4gKyAzMjsNCkBAIC0xMjQxLDEzICsxMjQ1LDE0 IEBADQogfQ0KIA0KIHN0YXRpYyBpbnQNCi1iZmVfZW5jYXAoc3RydWN0IGJm ZV9zb2Z0YyAqc2MsIHN0cnVjdCBtYnVmICptX2hlYWQsIHVfaW50MzJfdCAq dHhpZHgpDQorYmZlX2VuY2FwKHN0cnVjdCBiZmVfc29mdGMgKnNjLCBzdHJ1 Y3QgbWJ1ZiAqKm1faGVhZCwgdV9pbnQzMl90ICp0eGlkeCkNCiB7DQogCXN0 cnVjdCBiZmVfZGVzYyAqZCA9IE5VTEw7DQogCXN0cnVjdCBiZmVfZGF0YSAq ciA9IE5VTEw7DQogCXN0cnVjdCBtYnVmCSptOw0KIAl1X2ludDMyX3QJICAg ZnJhZywgY3VyLCBjbnQgPSAwOw0KIAlpbnQgY2hhaW5sZW4gPSAwOw0KKwlp bnQgZXJyb3I7DQogDQogCWlmKEJGRV9UWF9MSVNUX0NOVCAtIHNjLT5iZmVf dHhfY250IDwgMikNCiAJCXJldHVybiAoRU5PQlVGUyk7DQpAQCAtMTI1OCwx NiArMTI2MywxNiBAQA0KIAkgKiBieSBhbGwgcGFja2V0cywgd2UnbGwgbV9k ZWZyYWcgbG9uZyBjaGFpbnMgc28gdGhhdCB0aGV5DQogCSAqIGRvIG5vdCB1 c2UgdXAgdGhlIGVudGlyZSBsaXN0LCBldmVuIGlmIHRoZXkgd291bGQgZml0 Lg0KIAkgKi8NCi0JZm9yKG0gPSBtX2hlYWQ7IG0gIT0gTlVMTDsgbSA9IG0t Pm1fbmV4dCkNCisJZm9yKG0gPSAqbV9oZWFkOyBtICE9IE5VTEw7IG0gPSBt LT5tX25leHQpIHsNCiAJCWNoYWlubGVuKys7DQotDQorCX0NCiANCiAJaWYg KChjaGFpbmxlbiA+IEJGRV9UWF9MSVNUX0NOVCAvIDQpIHx8DQogCQkJKChC RkVfVFhfTElTVF9DTlQgLSAoY2hhaW5sZW4gKyBzYy0+YmZlX3R4X2NudCkp IDwgMikpIHsNCi0JCW0gPSBtX2RlZnJhZyhtX2hlYWQsIE1fRE9OVFdBSVQp Ow0KKwkJbSA9IG1fZGVmcmFnKCptX2hlYWQsIE1fRE9OVFdBSVQpOw0KIAkJ aWYgKG0gPT0gTlVMTCkNCiAJCQlyZXR1cm4gKEVOT0JVRlMpOw0KLQkJbV9o ZWFkID0gbTsNCisJCSptX2hlYWQgPSBtOw0KIAl9DQogDQogCS8qDQpAQCAt MTI3NSwxMSArMTI4MCwxMCBAQA0KIAkgKiB0aGUgZnJhZ21lbnQgcG9pbnRl cnMuIFN0b3Agd2hlbiB3ZSBydW4gb3V0DQogCSAqIG9mIGZyYWdtZW50cyBv ciBoaXQgdGhlIGVuZCBvZiB0aGUgbWJ1ZiBjaGFpbi4NCiAJICovDQotCW0g PSBtX2hlYWQ7DQogCWN1ciA9IGZyYWcgPSAqdHhpZHg7DQogCWNudCA9IDA7 DQogDQotCWZvcihtID0gbV9oZWFkOyBtICE9IE5VTEw7IG0gPSBtLT5tX25l eHQpIHsNCisJZm9yKG0gPSAqbV9oZWFkOyBtICE9IE5VTEw7IG0gPSBtLT5t X25leHQpIHsNCiAJCWlmKG0tPm1fbGVuICE9IDApIHsNCiAJCQlpZigoQkZF X1RYX0xJU1RfQ05UIC0gKHNjLT5iZmVfdHhfY250ICsgY250KSkgPCAyKQ0K IAkJCQlyZXR1cm4gKEVOT0JVRlMpOw0KQEAgLTEyOTksOSArMTMwMywxMyBA QA0KIAkJCQkgKi8NCiAJCQkJZC0+YmZlX2N0cmwgfD0gQkZFX0RFU0NfRU9U Ow0KIA0KLQkJCWJ1c19kbWFtYXBfbG9hZChzYy0+YmZlX3RhZywNCisJCQll cnJvciA9IGJ1c19kbWFtYXBfbG9hZChzYy0+YmZlX3RhZywNCiAJCQkgICAg ci0+YmZlX21hcCwgbXRvZChtLCB2b2lkKiksIG0tPm1fbGVuLA0KLQkJCSAg ICBiZmVfZG1hX21hcF9kZXNjLCBkLCAwKTsNCisJCQkgICAgYmZlX2RtYV9t YXBfZGVzYywgZCwgQlVTX0RNQV9OT1dBSVQpOw0KKwkJCWlmIChlcnJvcikg ew0KKwkJCQlwcmludGYoImRtYW1hcF9sb2FkIGVycm9yLCBFTk9CVUZTXG4i KTsNCisJCQkJcmV0dXJuIChFTk9CVUZTKTsNCisJCQl9DQogCQkJYnVzX2Rt YW1hcF9zeW5jKHNjLT5iZmVfdGFnLCByLT5iZmVfbWFwLA0KIAkJCSAgICBC VVNfRE1BU1lOQ19QUkVXUklURSk7DQogDQpAQCAtMTMxNSw3ICsxMzIzLDcg QEANCiAJCXJldHVybiAoRU5PQlVGUyk7DQogDQogCXNjLT5iZmVfdHhfbGlz dFtmcmFnXS5iZmVfY3RybCB8PSBCRkVfREVTQ19FT0Y7DQotCXNjLT5iZmVf dHhfcmluZ1tmcmFnXS5iZmVfbWJ1ZiA9IG1faGVhZDsNCisJc2MtPmJmZV90 eF9yaW5nW2ZyYWddLmJmZV9tYnVmID0gKm1faGVhZDsNCiAJYnVzX2RtYW1h cF9zeW5jKHNjLT5iZmVfdHhfdGFnLCBzYy0+YmZlX3R4X21hcCwgQlVTX0RN QVNZTkNfUFJFV1JJVEUpOw0KIA0KIAkqdHhpZHggPSBjdXI7DQpAQCAtMTM2 OCw3ICsxMzc2LDcgQEANCiAJCSAqIFBhY2sgdGhlIGRhdGEgaW50byB0aGUg dHggcmluZy4gIElmIHdlIGRvbnQgaGF2ZQ0KIAkJICogZW5vdWdoIHJvb20s IGxldCB0aGUgY2hpcCBkcmFpbiB0aGUgcmluZy4NCiAJCSAqLw0KLQkJaWYo YmZlX2VuY2FwKHNjLCBtX2hlYWQsICZpZHgpKSB7DQorCQlpZihiZmVfZW5j YXAoc2MsICZtX2hlYWQsICZpZHgpKSB7DQogCQkJSUZRX0RSVl9QUkVQRU5E KCZpZnAtPmlmX3NuZCwgbV9oZWFkKTsNCiAJCQlpZnAtPmlmX2Rydl9mbGFn cyB8PSBJRkZfRFJWX09BQ1RJVkU7DQogCQkJYnJlYWs7DQo= --0-125664624-1146464857=:731--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060501012306.G731>