From owner-cvs-all Sat Feb 10 9:36:23 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 692C137B4EC; Sat, 10 Feb 2001 09:36:03 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.2/8.11.2) id f1AHa2d75285; Sat, 10 Feb 2001 20:36:02 +0300 (MSK) (envelope-from ache) Date: Sat, 10 Feb 2001 20:36:01 +0300 From: "Andrey A. Chernov" To: Alexey Zelkin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale fix_grouping.c Makefile.inc lmonetary.c lnumeric.c localeconv.c Message-ID: <20010210203601.A75114@nagual.pp.ru> References: <200102101536.f1AFalt39792@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200102101536.f1AFalt39792@freefall.freebsd.org>; from phantom@FreeBSD.org on Sat, Feb 10, 2001 at 07:36:47AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Feb 10, 2001 at 07:36:47 -0800, Alexey Zelkin wrote: > phantom 2001/02/10 07:36:47 PST > > Modified files: > lib/libc/locale Makefile.inc lmonetary.c lnumeric.c > localeconv.c > Added files: > lib/libc/locale fix_grouping.c > Log: > . Fix semantics of grouping (LC_MONETARY::mon_grouping, > LC_NUMERIC::grouping) values. > . Always set __XXX_changed flags then loading numeric & monetary locale > categories to allow localeconv() to use C locale also. lmonetary.c lnumeric.c: C locale - numempty[] is wrong. It is double-converted as result. It must be "-1". Current path numempty -> cnv -> localeconv is "\x7F" -> 0 in your variant "-1" -> 0x7F in right variant fix_grouping.c: missing for isdigit() isdigit() arg must be casted to (unsigned char) -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message