From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:06:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD79F16A842; Sun, 3 Jul 2005 00:57:54 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4CCA4422E; Sun, 3 Jul 2005 00:40:27 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id D53EE6DAB3; Sat, 2 Jul 2005 17:37:50 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 602E45C9E8 for ; Thu, 20 Jan 2005 17:23:33 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 4B15556F54 for ; Fri, 21 Jan 2005 01:23:33 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id D52A016A539; Fri, 21 Jan 2005 01:23:28 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id D871016A4D0; Fri, 21 Jan 2005 01:23:26 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA86416A4CE; Fri, 21 Jan 2005 01:23:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C984643D2D; Fri, 21 Jan 2005 01:23:25 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j0L1NPHg009493; Fri, 21 Jan 2005 01:23:25 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j0L1NP1u009492; Fri, 21 Jan 2005 01:23:25 GMT (envelope-from peter) Message-Id: <200501210123.j0L1NP1u009492@repoman.freebsd.org> From: Peter Wemm To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: Subject: cvs commit: src/sys/nfs nfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:06:53 -0000 X-Original-Date: Fri, 21 Jan 2005 01:23:25 +0000 (UTC) X-List-Received-Date: Sun, 03 Jul 2005 01:06:53 -0000 peter 2005-01-21 01:23:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/nfs nfs_vfsops.c Log: Yet another pass on trying to fix the nfs statfs large-fs blocksize scaler. Casting the result of the 64 bit division to 32 bits (thus discarding the upper 32 bits) and then looking at the truncated result to try and figure out if the untruncated result would fit in 32 bits was utterly useless. I am still not sure that it is right, but it has a chance of working now. I'm not at all sure about the sign handling. NFSv3 only reports positive values here, but correctness of handling the 63/64 bit signs on nfs volumes is not a problem we'll likely have to deal with for some time. I think the "most correct" test is for an unsigned division testing for exceeding LONG_MAX, since we should never end up with a negative number to compare against LONG_MIN. Revision Changes Path 1.91.2.9 +6 -6 src/sys/nfs/nfs_vfsops.c