From owner-freebsd-ports-bugs@freebsd.org Thu Sep 12 09:04:09 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3F839F04F8 for ; Thu, 12 Sep 2019 09:04:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46TXrT10c7z41PY for ; Thu, 12 Sep 2019 09:04:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 224D1F04F7; Thu, 12 Sep 2019 09:04:09 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 22154F04F6 for ; Thu, 12 Sep 2019 09:04:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TXrT07KFz41PX for ; Thu, 12 Sep 2019 09:04:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DC4341C739 for ; Thu, 12 Sep 2019 09:04:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8C948EL093586 for ; Thu, 12 Sep 2019 09:04:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8C948Hl093573 for ports-bugs@FreeBSD.org; Thu, 12 Sep 2019 09:04:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240526] x11/xlockmore: fix XLOCKLIBS if both MESAGL & KERBEROS5 options set (also KERBEROS5 is broken) Date: Thu, 12 Sep 2019 09:04:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jgh@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 09:04:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240526 Bug ID: 240526 Summary: x11/xlockmore: fix XLOCKLIBS if both MESAGL & KERBEROS5 options set (also KERBEROS5 is broken) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: jgh@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com Assignee: jgh@FreeBSD.org Flags: maintainer-feedback?(jgh@FreeBSD.org) Created attachment 207409 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207409&action= =3Dedit [patch] allow multiple values for XLOCKLIBS, fix KERBEROS5 If both MESAGL & KERBEROS5 options set, XLOCKLIBS is defined separately twi= ce in CONFIGURE_ENV (the last one winning). Also, KERBEROS5 was broken. If you build with KERBEROS5 option and either KRB5_HOME=3D/usr/local and security/krb5 installed OR with KRB5_HOME=3D/usr= , you get a link error: ../xlock/passwd.o: In function `checkPasswd': passwd.c:(.text+0x8f): undefined reference to `krb5_get_init_creds_opt_init' passwd.c:(.text+0x9b): undefined reference to `krb5_init_context' passwd.c:(.text+0xb5): undefined reference to `com_err' passwd.c:(.text+0xdb): undefined reference to `krb5_parse_name' passwd.c:(.text+0x100): undefined reference to `krb5_cc_default' passwd.c:(.text+0x11a): undefined reference to `com_err' . . Finally, USE_GL by itself is deprecated: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Using USE_GL alone is deprecated, please add USES=3Dgl. USE_GL=3Dyes is deprecated, please add USE_GL=3Dglu (default) or specify co= mponent =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The attached patch addresses these issues: - Fix USES/USE_GL for gl components (MESAGL) - Fix kerberos libs (link error) & add USES=3Dgssapi:mit (KERBEROS5) [1] - Fix XLOCKLIBS when both MESAGL & KERBEROS5 are selected [1] Instead of USES=3Dgssapi:mit in the patch, we could provide an option f= or selecting which kerberos implementation to use. Other ports provide a radio choice for the other kerberos options (mit, heimdal, base) - e.g., see net/wireshark and net/samba410. Allowing a kerberos option choice could be added later. QA: poudriere testport with MESAGL & KERBEROS5 set: ok portlint: patch fixes a previous portlint warning [2] [2] WARN: Makefile: "BROKEN" has to appear earlier. --=20 You are receiving this mail because: You are the assignee for the bug.=