From owner-freebsd-current Fri Sep 18 11:44:28 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA08455 for freebsd-current-outgoing; Fri, 18 Sep 1998 11:44:28 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from pluto.plutotech.com (mail.plutotech.com [206.168.67.137]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA08422; Fri, 18 Sep 1998 11:44:21 -0700 (PDT) (envelope-from gibbs@plutotech.com) Received: from narnia.plutotech.com (narnia.plutotech.com [206.168.67.130]) by pluto.plutotech.com (8.8.7/8.8.5) with ESMTP id MAA01379; Fri, 18 Sep 1998 12:43:40 -0600 (MDT) Message-Id: <199809181843.MAA01379@pluto.plutotech.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Stefan Eggers cc: dag-erli@ifi.uio.no (Dag-Erling =?iso-8859-1?Q?Co=EFdan?= =?iso-8859-1?Q?Sm=F8rgrav?= ), Timo Geusch , current@FreeBSD.ORG, gibbs@FreeBSD.ORG Subject: Re: DEVFS & SLICE? In-reply-to: Your message of "Fri, 18 Sep 1998 19:18:27 +0200." <199809181718.TAA01882@semyam.dinoco.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 18 Sep 1998 12:37:19 -0600 From: "Justin T. Gibbs" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >It's not my PR but I think the correction is simple: Put the two >functions (scsi_start_stop and scsi_read_write I think were their >names) in a file named something like scsi_common.c, header file >scsi_common.h, remove them from scsi_da.c and scsi_da.h and then >add it to sys/conf/files to be included for cd and da device >entries in the kernel configuration. If we decide to move them, they should go in scsi_all.c. I'm just not sure that they should be moved. The two functions are not common to all devices. They are common to direct access devices (i.e. defined in section 9 of the SCSI2 spec). CDROMs are a superset of direct access devices, so they require the DA files to be compiled in as well. I'll see if config will allow us to add a second dependency on the da files based on the cd driver. I believe that the generic peripheral driver error handler also makes use of scsi_start_stop if the device encountering an error is a direct access or cdrom device. I'll have to check. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message