From owner-freebsd-alpha Thu Jan 4 14:53:30 2001 From owner-freebsd-alpha@FreeBSD.ORG Thu Jan 4 14:53:28 2001 Return-Path: Delivered-To: freebsd-alpha@freebsd.org Received: from front1m.grolier.fr (front1m.grolier.fr [195.36.216.51]) by hub.freebsd.org (Postfix) with ESMTP id 6594037B400 for ; Thu, 4 Jan 2001 14:53:27 -0800 (PST) Received: from nas1-55.mea.club-internet.fr (nas1-55.mea.club-internet.fr [195.36.139.55]) by front1m.grolier.fr (8.9.3/No_Relay+No_Spam_MGC990224) with ESMTP id XAA06017; Thu, 4 Jan 2001 23:53:23 +0100 (MET) Date: Thu, 4 Jan 2001 22:52:56 +0100 (CET) From: =?ISO-8859-1?Q?G=E9rard_Roudier?= X-Sender: groudier@linux.local To: Andrew Gallatin Cc: freebsd-alpha@FreeBSD.ORG Subject: Re: bus_dmamap_load In-Reply-To: <14932.59983.360316.243974@grasshopper.cs.duke.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Thu, 4 Jan 2001, Andrew Gallatin wrote: > G=E9rard Roudier writes: > > Btw, you missed the `de' driver that also performs bus_dmamap_load() o= n > > mbuf's as a possible candidate. > >=20 >=20 > Does it actually do this? I see all the code protected by: >=20 > =09#if defined(TULIP_BUS_DMA) >=20 > But I do not see TULIP_BUS_DMA defined anywhered. I think it was > inherited from NetBSD and the define was clobbered in Indeed. I missed that. But the sym driver only calls bus_dmamap_load() in 2 places: 1) Using an hardcoded value for buflen (1 PAGE) for internal data structures allocation. 2) Using `csio->dxfer_len' when preparing an IO for the DMA. Place (1) is unlikely to lead to a size problem, and (2) is provided by CAM or upper layer. If there is a driver bug in driver code path (2), then it should likely have already triggerred, in my opinion. G=E9rard. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message