Date: Wed, 14 Nov 2018 10:58:04 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 233195] lang/cmucl-extra: Update to 21.b, Take MAINTAINER'ship Message-ID: <bug-233195-7788-2Ct2Ypf4e5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233195-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-233195-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233195 Lorenzo Salvadore <phascolarctos@protonmail.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199202|0 |1 is obsolete| | Attachment #199231| |maintainer-approval+ Flags| | --- Comment #2 from Lorenzo Salvadore <phascolarctos@protonmail.ch> --- Created attachment 199231 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D199231&action= =3Dedit cmucl-extra patch, correction 1 Here is the patch corrected, with some more information. - As for the PORTVERSION with letters, it is allowed. Indeed, I defined DISTVERSION and PORTVERSION was deduced from it. I already checked in bug #232011 that passing from defining PORTVERSION to defining DISTVERSION keeps PORTVERSION increasing. - I fixed the order of variables as requested. - The plist is correct (I checked again with poudriere after I did some cha= nge to install the message catalog files in the right directory). It looks funny that it depends on the NLS option although the only instruction in the Make= file dependent on NLS is NLS_USES=3D gettext, because this line also takes care = of installing conditionally the message catalog files. See https://www.freebsd.org/doc/en/books/porters-handbook/using-gettext.html, in particular "The Makefile part of this task is already provided by the idiom= ". - MASTER_SITES have been changed to the actual official sites for downloadi= ng cmucl-extra. - I removed the build dependency on lang/cmucl because this port has NO_BUI= LD set, so no real build dependencies. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233195-7788-2Ct2Ypf4e5>