Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Oct 2009 11:03:21 +0200
From:      Adrian Penisoara <ady@freebsd.ady.ro>
To:        Max Laier <max@love2party.net>
Cc:        freebsd-hackers@freebsd.org, Rink Springer <rink@freebsd.org>, Ivan Voras <ivoras@freebsd.org>
Subject:   Re: Make process title - % complete
Message-ID:  <78cb3d3f0910210203n66b0b08bl1bbfb3db7ec7e024@mail.gmail.com>
In-Reply-To: <200910210311.54871.max@love2party.net>
References:  <hbhquj$mkj$1@ger.gmane.org> <20091019140806.GB95902@rink.nu>  <200910210311.54871.max@love2party.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

On Wed, Oct 21, 2009 at 3:11 AM, Max Laier <max@love2party.net> wrote:
> On Monday 19 October 2009 16:08:06 Rink Springer wrote:
>> Hi Ivan,
>>
>> On Mon, Oct 19, 2009 at 03:52:30PM +0200, Ivan Voras wrote:
>> > if nobody objects, I'll commit it :)
>>
>> I seem to recall that setproctitle() is quite expensive to call; perhaps
>> it would make sense offer a flag to prevent make(1) from calling it? [1]
>
> Just rate-limit the setproctitle() call to once/sec or once/percentage-st=
ep
> and be done with it.

Rather try to setproctitle() in the same make process every second
with a one second initial delay (so that short lived make processes
won't be bogged down by this expensive call). And preferentially do
the timing check after returning from exec() of a child make.

 This way the stats won't be "perturbed" by the short lived make's and
only one make process will call setproctitle() at any time (except
when running "make -j" ?).

>
> I must say that trying it out on a kernel build didn't proof too useful a=
s the
> targets have vastly different runtimes, but I think it's a good addition
> nonetheless. =A0So please, go for it Ivan.
>

If you implement it, please use a control mechanism like, say, an
environment variable MAKE_TRACK_PROGRESS, which, for performance and
POLA sake, might default to disabled (including when environment is
not defined).

My 5cents,
Adrian Penisoara
EnterpriseBSD.com



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?78cb3d3f0910210203n66b0b08bl1bbfb3db7ec7e024>