From owner-cvs-usrbin Wed Sep 24 19:20:48 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id TAA16986 for cvs-usrbin-outgoing; Wed, 24 Sep 1997 19:20:48 -0700 (PDT) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id TAA16959; Wed, 24 Sep 1997 19:20:36 -0700 (PDT) Received: from spinner.netplex.com.au (localhost.dialix.com.au [127.0.0.1]) by spinner.netplex.com.au with ESMTP id KAA01317; Thu, 25 Sep 1997 10:20:09 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199709250220.KAA01317@spinner.netplex.com.au> X-Mailer: exmh version 2.0zeta 7/24/97 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= cc: Julian Elischer , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-include@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG Subject: Re: cvs commit: src/include ctype.h src/lib/libc/db/man Makefile.inc src/lib/libc/locale mskanji.c Makefile.inc isctype.c setrunelocale.c src/usr.bin/mklocale/data ja_JP.SJIS.src Makefile In-reply-to: Your message of "Thu, 25 Sep 1997 01:57:10 +0400." Date: Thu, 25 Sep 1997 10:20:08 +0800 From: Peter Wemm Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= wrote: > On Wed, 24 Sep 1997, Julian Elischer wrote: > > > lib/libc/locale Makefile.inc isctype.c setrunelocale.c > > MSKanji should be moved under XPG4 define (like EUC) since our libc is not > yet 16bit clean. Setting LANG to MSKanji will cause great damage for all > non-X11 programs - it was the reason why separate library was created - > only for programs which are 16bit aware, not for standard 8bit programs. > Please fix or let me. Not only that, but this commit breaks the build!! After rebuilding includes (and triple checking), the ctype.h file preprocesses as: static __inline int __maskrune(_BSD_RUNE_T_ c, unsigned long f) { return(((c & (~((1 <<8 ) - 1)) ) ? ___runetype(c) : _CurrentRuneLocale->runetype[c]) & f); } from (at least) usr.bin/systat/cmds.c. cmds.c #includes the following in this order: #include #include #include #include I suspect this happens because of: #ifdef _BSD_RUNE_T_ typedef _BSD_RUNE_T_ rune_t; #undef _BSD_RUNE_T_ ^^^^^^^^^^^^^^^^^^^^ #endif #endif and _BSD_RUNE_T_ is used explicitly in ctype.h.. It was #defined once in but won't be redefined again a second time due to the multiple include protection. Cheers, -Peter -- Peter Wemm Netplex Consulting