From owner-freebsd-arch Wed May 9 10:23:51 2001 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 61B5037B422; Wed, 9 May 2001 10:23:48 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.3/8.11.3) with SMTP id f49HNif90229; Wed, 9 May 2001 13:23:45 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Wed, 9 May 2001 13:23:44 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: John Baldwin Cc: arch@FreeBSD.org Subject: RE: Patch to eliminate struct pcred In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 9 May 2001, John Baldwin wrote: > Some comments: > > @@ -274,21 +275,31 @@ > ... > - (p->p_flag & P_TRACED) == 0) { > + p->p_flag & P_TRACED) { > ... > > It looks like you've inverted the sense of that test. Oops, nice catch. I've now fixed that. > What is the XXX: locking comment about here: > > @@ -296,25 +307,50 @@ > + p->p_flag &= ~P_SUGID; /* XXX locking */ > PROC_UNLOCK(p); > > The process is locked when that flag is cleared. This is from an earlier incarnation where I had the locking rearranged some. It no longer applies, so I've removed it. A patch with those changes (only) is available at: http://www.watson.org/~robert/pcred.3.diff Thanks again, Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message