From owner-svn-src-all@FreeBSD.ORG Thu Jun 4 08:09:06 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 06136749; Thu, 4 Jun 2015 08:09:06 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B2E31506; Thu, 4 Jun 2015 08:09:05 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wiga1 with SMTP id a1so39066035wig.0; Thu, 04 Jun 2015 01:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=A24LIapDc5LEUiLSbBlt07TteVbvl1nxJlp3ej99a9w=; b=al0yO6JbewQa1Sd1rIp3TwWA2gPXbYrfE4lNFBKFgAqJTWPNe+zpJJBT+5iFTX4flb y9X6QKGQkfPOTwmIwoZXeYqYF1+hBXWiUDw0Tmu4qwvI8o5lXGfK5rF0j44InbEw97zu crYW+h1da32iaHvbocdq2jtZvqnPOnUcWBopcZAVS+K6L9qQ8fz+NrH0wzLygcfDHidk BO5k/EdovCUS5YGPNgDtj3M6CrA1KtXxT34M8mrJHX6i6OeZW8BTkOKgl3Gj95xhtmfA md5ZGGjdLeKFZ2BaX3rI7rtxdQOyCtkNW/905Whk6zveKZWiEi1sa9Syva3lW6jjACSQ HuJg== X-Received: by 10.180.215.101 with SMTP id oh5mr5450843wic.6.1433405343968; Thu, 04 Jun 2015 01:09:03 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id y19sm5137939wia.15.2015.06.04.01.09.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 01:09:01 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 4 Jun 2015 10:08:59 +0200 From: Baptiste Daroussin To: Xin Li Cc: d@delphij.net, Sergey Kandaurov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, nectar@FreeBSD.org Subject: Re: svn commit: r283969 - head/lib/libutil Message-ID: <20150604080858.GA1832@ivaldir.etoilebsd.net> References: <201506032048.t53KmSCf074619@svn.freebsd.org> <20150603215841.GF32562@ivaldir.etoilebsd.net> <556F8322.9050602@delphij.net> <20150604052120.GH32562@ivaldir.etoilebsd.net> <557003DA.9090205@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <557003DA.9090205@delphij.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 08:09:06 -0000 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 04, 2015 at 12:52:58AM -0700, Xin Li wrote: >=20 >=20 > On 6/3/15 22:21, Baptiste Daroussin wrote: > > On Wed, Jun 03, 2015 at 03:43:46PM -0700, Xin Li wrote: > >> On 06/03/15 14:58, Baptiste Daroussin wrote: > >>> On Thu, Jun 04, 2015 at 12:51:46AM +0300, Sergey Kandaurov > >>> wrote: > >>>> On 3 June 2015 at 23:48, Baptiste Daroussin > >>>> wrote: > >>>>> Author: bapt Date: Wed Jun 3 20:48:28 2015 New Revision:=20 > >>>>> 283969 URL: > >>>>> https://svnweb.freebsd.org/changeset/base/283969 > >>>>>=20 > >>>>> Log: Add a pw_mkdb2(3) function which does the same thing > >>>>> as pw_mkdb(3) except it takes a new argument allowing to > >>>>> specify the endianness of the database to generate > >>>>>=20 > >>>>=20 > >>>> Why not change pw_mkdb()? Is it used outside of the project? > >>>>=20 > >>> Because that would change the ABI of libutil and it is not a=20 > >>> private library aka we are supposed to maintain ABI > >>> compatibility as we do not know if it is used or not externally > >>> to the project. I care about the ABI because I have made this > >>> change in order to use it in pw(8) and MFC it to stable/10 > >>> before 10.2. > >>>=20 > >>> libutil is not versionned so this is the only way to not break > >>> the ABI. Except if someone has a better idea than I do. > >>=20 > >> Looking at r113596, pwd_mkdb(8) was changed to generate both > >> legacy (version 3, endianness sensitive) and new (version 4, > >> machine independent) formats. > >>=20 > >> Now, after 12 years, is it still sensible to generate legacy > >> format db entries? Maybe we should just disable the generation > >> by default and eventually remove the ability to generate them? > >>=20 > >=20 > > That could be an option, in this case we could add a -l (legacy) > > option to pwd_mkdb to allow the users to generate the db in legacy > > format and drop support support for legacy format in all other > > tools. Meaning I can revert pw_mkdb2(3) >=20 > Well, I think the pw_mkdb2(3) should be reverted, because the base > system libraries are not using the legacy format when new formatted > entries are present (which is true for databases generated on FreeBSD > 5+); and if they do, that shall be seen as a bug and we should fix > these libraries. >=20 > I have committed r283981-r283983 to implement the default change and > the -l option. >=20 done, thank you! Bapt --T4sUOijqQbZv57TR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVwB5oACgkQ8kTtMUmk6ExTWgCgoVXuu1hJui9ADtOuPaDR38Wi bW8Anj7z++CJVQoLe0gDlf4oDvsVkevi =6Mo0 -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--