From owner-cvs-src@FreeBSD.ORG Mon Feb 16 11:13:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6FEB16A4D1; Mon, 16 Feb 2004 11:13:56 -0800 (PST) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5FDE43D1F; Mon, 16 Feb 2004 11:13:56 -0800 (PST) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 70FB2530D; Mon, 16 Feb 2004 20:13:55 +0100 (CET) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id EEF6E5308; Mon, 16 Feb 2004 20:13:47 +0100 (CET) Received: by dwp.des.no (Postfix, from userid 2602) id 8FB8F33C6F; Mon, 16 Feb 2004 20:13:47 +0100 (CET) To: Robert Watson References: From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Mon, 16 Feb 2004 20:13:47 +0100 In-Reply-To: (Robert Watson's message of "Mon, 16 Feb 2004 13:55:51 -0500 (EST)") Message-ID: User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2004 19:13:57 -0000 Robert Watson writes: > On Mon, 16 Feb 2004, Dag-Erling Smorgrav wrote: > > Log: > > Don't panic if we fail to satisfy an M_WAITOK request; return 0 inste= ad. > > The calling code will either handle that gracefully or cause a page f= ault. > This substantially modifies the semantics of the two consumers of > kmem_malloc(), and those semantic changes trickle up the stack to a number > of important places. Are you going to update the consumers (and their > comments) as well? This can only happen if you request a ridiculously large allocation; if you actually run out of memory (e.g. due to a leak) you will get "out of swap space" or similar errors instead. There are several cases in which kmem_malloc() would previously trigger "kmem_map too small" even though the caller could recover gracefully if given half a chance. Before this patch there was no incentive to fix those cases because you'd never get a change to try to recover anyway. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no