Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Sep 2011 17:21:16 +0400
From:      h h <aakuusta@gmail.com>
To:        Emanuel Haupt <ehaupt@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/audio/xmp Makefile ports/audio/xmp/files patch-audio__xmp__files__patch-configure
Message-ID:  <861uvo1qk3.fsf@gmail.com>
In-Reply-To: <201109100956.p8A9uVvZ089948__16543.6287098148$1315648633$gmane$org@repoman.freebsd.org> (Emanuel Haupt's message of "Sat, 10 Sep 2011 09:56:31 %2B0000 (UTC)")
References:  <201109100956.p8A9uVvZ089948__16543.6287098148$1315648633$gmane$org@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Emanuel Haupt <ehaupt@FreeBSD.org> writes:

> ehaupt      2011-09-10 09:56:31 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     audio/xmp            Makefile 
>   Added files:
>     audio/xmp/files      patch-audio__xmp__files__patch-configure 
>   Log:
>   Fix autodetection of <sys/rtprio.h> which currently fails due to missing
>   typedefs provided by <sys/types.h>.
>   
>   PR:             160597
>   Submitted by:   aakuusta@gmail.com
>   
[...]
>   Revision  Changes    Path
>   1.1       +14 -0     ports/audio/xmp/files/patch-audio__xmp__files__patch-configure (new)

Don't you find something wrong? The PR contained a ready-to-commit patch, e.g.

  # include only `Description' contents in commit log
  $ cat >> .git/hooks/applypatch-msg && chmod +x .git/hooks/applypatch-msg
  sed -i '' '1,/^>Description:/Id; />[-[:alnum:]]*:/,$d' "$@"

  # apply and generate a commit that can be pushed with `git cvsexportcommit'
  $ fetch -qo- 'http://www.freebsd.org/cgi/query-pr.cgi?pr=160597&f=raw' \
        | git am

Not sure what tool you used for pre-processsing the patch but it was unnecessary.

  $ make patch
  $ diff $(make -V WRKSRC)/configure{.orig,}
  diff: /usr/ports/audio/xmp/work/xmp-3.4.1/configure.orig: No such file or directory
  $ ls $(make -V WRKSRC)/**/*configure*
  /usr/ports/audio/xmp/work/xmp-3.4.1/audio/xmp/files/patch-configure
  /usr/ports/audio/xmp/work/xmp-3.4.1/audio/xmp/files/patch-configure.orig
  /usr/ports/audio/xmp/work/xmp-3.4.1/configure*
  /usr/ports/audio/xmp/work/xmp-3.4.1/configure.bak*
  /usr/ports/audio/xmp/work/xmp-3.4.1/configure.in



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?861uvo1qk3.fsf>