From owner-svn-src-all@FreeBSD.ORG Fri Apr 24 15:17:44 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E628B422; Fri, 24 Apr 2015 15:17:44 +0000 (UTC) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id C96DB1891; Fri, 24 Apr 2015 15:17:44 +0000 (UTC) Received: from marvin.lab.vangyzen.net (c-73-147-253-17.hsd1.va.comcast.net [73.147.253.17]) by smtp.vangyzen.net (Postfix) with ESMTPSA id C907156467; Fri, 24 Apr 2015 10:17:43 -0500 (CDT) Message-ID: <553A5E9B.7090503@FreeBSD.org> Date: Fri, 24 Apr 2015 11:17:47 -0400 From: Eric van Gyzen User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: John Baldwin , Sergey Kandaurov CC: Edward Tomasz Napierala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281922 - head/usr.bin/nfsstat References: <201504240758.t3O7w0o1022549@svn.freebsd.org> <1589639.roM6gzoYx3@ralph.baldwin.cx> In-Reply-To: <1589639.roM6gzoYx3@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2015 15:17:45 -0000 On 04/24/2015 10:33, John Baldwin wrote: > On Friday, April 24, 2015 02:31:31 PM Sergey Kandaurov wrote: >> On 24 April 2015 at 10:58, Edward Tomasz Napierala wrote: >>> Author: trasz >>> Date: Fri Apr 24 07:57:59 2015 >>> New Revision: 281922 >>> URL: https://svnweb.freebsd.org/changeset/base/281922 >>> >>> Log: >>> Make nfsstat(1) build with WARNS=6. >>> >>> Sponsored by: The FreeBSD Foundation >>> >>> Modified: >>> head/usr.bin/nfsstat/Makefile >>> head/usr.bin/nfsstat/nfsstat.c >>> >>> Modified: head/usr.bin/nfsstat/Makefile >>> ============================================================================== >>> --- head/usr.bin/nfsstat/Makefile Fri Apr 24 07:52:21 2015 (r281921) >>> +++ head/usr.bin/nfsstat/Makefile Fri Apr 24 07:57:59 2015 (r281922) >>> @@ -6,6 +6,4 @@ CFLAGS+=-DNFS >>> >>> LIBADD= kvm >>> >>> -WARNS?= 3 >>> - >>> .include >>> >>> Modified: head/usr.bin/nfsstat/nfsstat.c >>> ============================================================================== >>> --- head/usr.bin/nfsstat/nfsstat.c Fri Apr 24 07:52:21 2015 (r281921) >>> +++ head/usr.bin/nfsstat/nfsstat.c Fri Apr 24 07:57:59 2015 (r281922) >>> @@ -70,15 +70,6 @@ static const char rcsid[] = >>> #include >>> #include >>> >>> -struct nlist nl[] = { >>> -#define N_NFSSTAT 0 >>> - { .n_name = "nfsstats" }, >>> -#define N_NFSRVSTAT 1 >>> - { .n_name = "nfsrvstats" }, >>> - { .n_name = NULL }, >>> -}; >>> -kvm_t *kd; >>> - >>> static int widemode = 0; >>> static int zflag = 0; >>> static int printtitle = 1; >>> >> >> Now that nfsstat no longer uses kvm to extract statistics, it could be >> further trimmed. >> - no longer link with kvm >> - un-document -M/-N options but still kept (?) for backward compatibility >> - cleanup from the previous sysctl/kvm usage. > > If these are just global structures in the kernel it would be nice to keep > -N/-M support for use in crash dump reporting. This just broke crashinfo > (again), so please either restore KVM support for crash reporting, or > remove nfsstat from crashinfo. ...or implement debugger scripts that provide similar functionality, and call those from crashinfo. Eric