From owner-freebsd-arm@FreeBSD.ORG Sat Jun 9 06:04:11 2012 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 988D81065675 for ; Sat, 9 Jun 2012 06:04:11 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from smtp3.clear.net.nz (smtp3.clear.net.nz [203.97.33.64]) by mx1.freebsd.org (Postfix) with ESMTP id 5F3598FC17 for ; Sat, 9 Jun 2012 06:04:11 +0000 (UTC) Received: from mxin2-orange.clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp3.clear.net.nz (CLEAR Net Mail) with ESMTP id <0M5C006Y766SC730@smtp3.clear.net.nz> for freebsd-arm@freebsd.org; Sat, 09 Jun 2012 18:04:04 +1200 (NZST) Received: from 202-0-48-19.paradise.net.nz (HELO localhost) ([202.0.48.19]) by smtpin2.paradise.net.nz with ESMTP; Sat, 09 Jun 2012 18:04:04 +1200 Date: Sat, 09 Jun 2012 18:03:32 +1200 From: Andrew Turner In-reply-to: <6B3D6C60-C1C9-442A-A223-C88C42FAE422@bsdimp.com> To: Warner Losh Message-id: <20120609180332.53c42ede@fubar.geek.nz> MIME-version: 1.0 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.0) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Pirate: Arrrr References: <20120609161132.38066a60@fubar.geek.nz> <6B3D6C60-C1C9-442A-A223-C88C42FAE422@bsdimp.com> Cc: freebsd-arm@freebsd.org Subject: Re: Small initarm cleanup X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jun 2012 06:04:11 -0000 On Fri, 8 Jun 2012 23:32:58 -0600 Warner Losh wrote: > This looks great! I didn't verify each and every instance is exactly > identical, but the quick eyeball check says it looks great. The only difference I noticed is, two files call proc_linkup rather than proc_linkup0. The only difference between these two functions is proc_linkup0 initialises the proc's p_threads tailq then calls proc_linkup. As one of these is in the s3c24x0 version of initarm, which I have hardware for, I have tested it work as expected. Andrew