From owner-freebsd-current@FreeBSD.ORG  Wed Sep  3 15:03:14 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5923816A4BF
	for <current@freebsd.org>; Wed,  3 Sep 2003 15:03:14 -0700 (PDT)
Received: from mail.liwing.de (mail.liwing.de [213.70.188.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C38C943FEC
	for <current@freebsd.org>; Wed,  3 Sep 2003 15:03:12 -0700 (PDT)
	(envelope-from rehsack@liwing.de)
Received: (qmail 58739 invoked from network); 3 Sep 2003 22:03:08 -0000
Received: from stingray.liwing.de (HELO liwing.de) ([213.70.188.164])
          (envelope-sender <rehsack@liwing.de>)
          by mail.liwing.de (qmail-ldap-1.03) with SMTP
          for <mime@traveller.cz>; 3 Sep 2003 22:03:08 -0000
Message-ID: <3F56651C.5050108@liwing.de>
Date: Wed, 03 Sep 2003 22:03:08 +0000
From: Jens Rehsack <rehsack@liwing.de>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20030821
X-Accept-Language: de-de, de, en-us, en
MIME-Version: 1.0
To: Michal Mertl <mime@traveller.cz>
References: <Pine.BSF.4.41.0212081046090.73179-200000@prg.traveller.cz>
In-Reply-To: <Pine.BSF.4.41.0212081046090.73179-200000@prg.traveller.cz>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: roger@freebsd.org
cc: current@freebsd.org
Subject: Re: bktr(4) bufs plus patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Sep 2003 22:03:14 -0000

Michal Mertl wrote:
> I found 2 bugs and some potential problems in bktr(4) code.
> 
> Bug 1:
> Compilation with options BKTR_USE_FREEBSD_SMBUS failes. Error is
> that code tries to use iicbus which isn't defined where it looks for
> it. I added it there and the compilation and detection goes fine. I don't
> know how to actually test it though.
> 

[...]

Will anyone responsible take notice of this patch and commit it?

> ------------------------------------------------------------------------
> 
> *** dev/bktr/bktr_reg.h.ori	Sun Dec  8 10:40:14 2002
> --- dev/bktr/bktr_reg.h	Sun Dec  8 10:40:38 2002
> ***************
> *** 448,453 ****
> --- 448,454 ----
>   struct bktr_i2c_softc {
>   	int bus_owned;
>   
> + 	device_t iicbus;
>   	device_t iicbb;
>   	device_t smbus;
>   };
> *** dev/bktr/bktr_os.c.ori	Sun Dec  8 10:39:13 2002
> --- dev/bktr/bktr_os.c	Sun Dec  8 10:39:35 2002
> ***************
> *** 499,513 ****
>   	destroy_dev(bktr->tunerdev);
>   	destroy_dev(bktr->bktrdev);
>   
> - 	/* If this is unit 0, then destroy the alias entries too */
> - #if (__FreeBSD_version >=500000)
> - 	if (unit == 0) {
> - 	    destroy_dev(bktr->vbidev_alias);
> - 	    destroy_dev(bktr->tunerdev_alias);
> - 	    destroy_dev(bktr->bktrdev_alias);
> - 	}
> - #endif
> - 
>   	/*
>   	 * Deallocate resources.
>   	 */
> --- 499,504 ----