From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 31 10:10:31 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0FDE16A4CE for ; Sun, 31 Oct 2004 10:10:30 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C539243D58 for ; Sun, 31 Oct 2004 10:10:30 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9VAAU7r040148 for ; Sun, 31 Oct 2004 10:10:30 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9VAAU3u040147; Sun, 31 Oct 2004 10:10:30 GMT (envelope-from gnats) Resent-Date: Sun, 31 Oct 2004 10:10:30 GMT Resent-Message-Id: <200410311010.i9VAAU3u040147@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tobias Roth Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EEDFC16A4CE for ; Sun, 31 Oct 2004 10:01:22 +0000 (GMT) Received: from secure.socket.ch (secure.socket.ch [212.254.206.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id F034643D54 for ; Sun, 31 Oct 2004 10:01:21 +0000 (GMT) (envelope-from roth@secure.socket.ch) Received: from secure.socket.ch (localhost [127.0.0.1]) by secure.socket.ch (8.12.10/8.12.5) with ESMTP id i9VA1K2I083808 for ; Sun, 31 Oct 2004 11:01:20 +0100 (CET) (envelope-from roth@secure.socket.ch) Received: (from roth@localhost) by secure.socket.ch (8.12.10/8.12.5/Submit) id i9VA1E7c083807; Sun, 31 Oct 2004 11:01:14 +0100 (CET) Message-Id: <200410311001.i9VA1E7c083807@secure.socket.ch> Date: Sun, 31 Oct 2004 11:01:14 +0100 (CET) From: Tobias Roth To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/73338: [patch] unbreak x11/login.app X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Tobias Roth List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 10:10:31 -0000 >Number: 73338 >Category: ports >Synopsis: [patch] unbreak x11/login.app >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Oct 31 10:10:30 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Tobias Roth >Release: FreeBSD 5.3-BETA7 i386 >Organization: >Environment: System: FreeBSD localhost 5.3-BETA7 FreeBSD 5.3-BETA7 #2: Wed Oct 13 08:25:14 CEST 2004 toor@localhost:/opt/obj/usr/src/sys/FOOBAR i386 >Description: This patch unbreaks x11/login.app. It substitutes a deprecated function that has been removed with the latest windowmaker update. Two files are added: files/patch-graphics.c files/patch-panel.c I intend to take maintainership and upgrade the port to the latest version later on. >How-To-Repeat: Build current x11/login.app from ports with all its latest deps. You'll see a linker error. >Fix: diff -ruN login.app.orig/files/patch-graphics.c login.app/files/patch-graphics.c --- login.app.orig/files/patch-graphics.c Thu Jan 1 01:00:00 1970 +++ login.app/files/patch-graphics.c Sun Oct 31 11:46:03 2004 @@ -0,0 +1,11 @@ +--- graphics.c.orig Sun Oct 31 11:44:10 2004 ++++ graphics.c Sun Oct 31 11:44:54 2004 +@@ -73,7 +73,7 @@ + img = RCloneImage(bottom); + RCombineImages(img, top); + setWindowImage(win, img); +- RDestroyImage(img); ++ RReleaseImage(img); + } + + void drawText(Window win, XFontStruct* font, int justification, int x, int y, diff -ruN login.app.orig/files/patch-panel.c login.app/files/patch-panel.c --- login.app.orig/files/patch-panel.c Thu Jan 1 01:00:00 1970 +++ login.app/files/patch-panel.c Sun Oct 31 11:46:18 2004 @@ -0,0 +1,11 @@ +--- panel.c.orig Sun Oct 31 11:44:16 2004 ++++ panel.c Sun Oct 31 11:44:41 2004 +@@ -297,7 +297,7 @@ + + image = RCreateImageFromDrawable(ctx, panel, 0); + RConvertImage(ctx, image, &shrinkPixmap); +- RDestroyImage(image); ++ RReleaseImage(image); + + XSetWindowBackgroundPixmap(dpy, panel, shrinkPixmap); + XUnmapSubwindows(dpy, panel); >Release-Note: >Audit-Trail: >Unformatted: