From owner-cvs-all Sat Feb 24 23:33:57 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 340A737B4EC; Sat, 24 Feb 2001 23:33:52 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA27742; Sun, 25 Feb 2001 18:33:50 +1100 Date: Sun, 25 Feb 2001 18:29:05 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf NOTES src/sys/conf options In-Reply-To: <200102241903.f1OJ3Jv66952@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 24 Feb 2001, John Baldwin wrote: > jhb 2001/02/24 11:03:19 PST > > Modified files: > sys/i386/conf NOTES > sys/conf options > Log: > Add back in INVARIANT_SUPPORT and expand the comments in NOTES about it > to include the reasoning Eivind justifiably thwapped me over the head with. Now removing INVARIANT_SUPPORT is back on my todo list :-]. It enables a whole 28 lines of code (the _mtx_assert() function). It seems to be normal for INVARIANTS support code to be this small, so I think it should be unconditional. You got thwapped because _mtx_assert() was conditional on the wrong option. The smallness may have something to do with large support code being put under other options, e.g., KTR. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message