Date: Wed, 15 Mar 2017 09:35:51 +0100 From: Torsten Zuehlsdorff <tz@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Remko Lodder <remko@freebsd.org> Subject: Re: svn commit: r436164 - in head/www/gitlab: . files Message-ID: <e6c16ef5-85bb-1597-ef25-fa1ae5e8bf5c@FreeBSD.org> In-Reply-To: <0cba26e2-c939-f205-59b3-04d30577a361@FreeBSD.org> References: <201703141639.v2EGdVx9035112@repo.freebsd.org> <0cba26e2-c939-f205-59b3-04d30577a361@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14.03.2017 21:22, Mathieu Arnold wrote: > Le 14/03/2017 à 17:39, Torsten Zuehlsdorff a écrit : >> +OPTIONS_SINGLE= DATABASE >> +OPTIONS_SINGLE_DATABASE= PGSQL MYSQL >> +OPTIONS_DEFAULT= PGSQL >> +PGSQL_DESC= Default PostgreSQL support (preferred) >> +MYSQL_DESC= Optional MySQL support > > Would it be possible to make that an OPTIONS_MULTI or OPTIONS_GROUP so > that both can be selected or none (for generic packaging) Not really useful, no. If none is selected, GitLab won't work at all. If MYSQL is selected, GitLab has known issues. If PGSQL is selected, everything is fine. There are some users who prefer to use MYSQL and can cope with the consequences. Any other should use just PostgreSQL. Therefore the choice of SINGLE. Also every option modifies the Gemfile when selected. So even with MULTI, the user would need to manually patch GitLab to be able to start. Greetings, Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e6c16ef5-85bb-1597-ef25-fa1ae5e8bf5c>