Date: Sun, 06 Jun 1999 20:42:38 -0700 From: Peter Wemm <peter@netplex.com.au> To: Nate Williams <nate@mt.sri.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfs nfs_socket.c Message-ID: <199906070342.UAA04118@peterw.yahoo.com> In-Reply-To: Your message of "Sun, 06 Jun 1999 21:08:51 MDT." <199906070308.VAA05778@mt.sri.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Williams wrote: > > peter 1999/06/06 17:53:13 PDT > > > > Modified files: (Branch: RELENG_2_1_0) > > sys/nfs nfs_socket.c > > Log: > > MFC: don't clobber a mbuf pointer > > Now *this* is a commit on a *very* old branch. :) Heh. There are a number of machines running it here... I have a handfull more changes, I was debating whether to bother or not, so tried a few of the easier ones. > Thanks for back-porting these changes! What's really bugging me right now is the good old block-of-nulls in vnode_if.c etc, and that's on an old 2.2.7-S client of a fairly recent 3.1-S server. The server copy is correct, and the client has the corrupted copy. It's even wierder that this client is the one that wrote the file in the first place, just moments before it tried to compile it and failed. I'm pretty sure I recall this particular problem getting fixed, but I don't remember if it was one of John Dyson's commits a while ago, one of Doug's, or one of Matt's in 4.0... I wish I had been paying more attention :-). The block of null chars goes from 0x3000 to 0x38bd.. Kinda wierd ending offset - nowhere near a block boundary - but it reminds me of the changes Matt made in his recent jumbo nfs patch to rework the piecemeal writes for the valid and/or dirty offset/end pointers. However, the end of the nulls is right in the middle of "&vop_mkdir_desc,\n", specifically everything except the "sc,\n" was clobbered. It doesn't even look like it would match a partial write boundary. > Nate Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199906070342.UAA04118>