Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Jun 2009 10:33:31 GMT
From:      Marko Zec <zec@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 164085 for review
Message-ID:  <200906111033.n5BAXV3x035759@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=164085

Change 164085 by zec@zec_tpx32 on 2009/06/11 10:33:31

	Improve style.
	Pointed out by:	bz

Affected files ...

.. //depot/projects/vimage-commit2/src/sys/netgraph/netgraph.h#27 edit
.. //depot/projects/vimage-commit2/src/sys/sys/proc.h#20 edit

Differences ...

==== //depot/projects/vimage-commit2/src/sys/netgraph/netgraph.h#27 (text+ko) ====

@@ -130,8 +130,7 @@
 #define HK_FORCE_WRITER		0x0004	/* Incoming data queued as a writer */
 #define HK_DEAD			0x0008	/* This is the dead hook.. don't free */
 #define HK_HI_STACK		0x0010	/* Hook has hi stack usage */
-#define HK_TO_INBOUND		0x0020	/* Hook calls into the inbound path
-					   of the network stack.  */
+#define HK_TO_INBOUND		0x0020	/* Hook on ntw. stack inbound path. */
 
 /*
  * Public Methods for hook
@@ -1208,16 +1207,16 @@
 /*
  * Mark the current thread when called from the outbound path of the
  * network stack, in order to enforce queuing on ng nodes calling into
- * the inbound network stack path..
+ * the inbound network stack path.
  */
 #define NG_OUTBOUND_THREAD_REF()					\
-	curthread->td_ng_outbound++;
+	curthread->td_ng_outbound++
 #define NG_OUTBOUND_THREAD_UNREF()					\
 	do {								\
 		curthread->td_ng_outbound--;				\
 		KASSERT(curthread->td_ng_outbound >= 0,			\
 		    ("%s: negative td_ng_outbound", __func__));		\
-	} while (0);
+	} while (0)
 
 /* Virtualization macros */
 #define	INIT_VNET_NETGRAPH(vnet) \

==== //depot/projects/vimage-commit2/src/sys/sys/proc.h#20 (text+ko) ====

@@ -278,8 +278,8 @@
 	struct lpohead	td_lprof[2];	/* (a) lock profiling objects. */
 	struct kdtrace_thread	*td_dtrace; /* (*) DTrace-specific data. */
 	int		td_errno;	/* Error returned by last syscall. */
-	struct vnet	*td_vnet;	/* (k) Effective vnet. */
-	const char	*td_vnet_lpush;	/* (k) Debugging vnet push / pop. */
+	struct vnet	*td_vnet;	/* (*) Effective vnet. */
+	const char	*td_vnet_lpush;	/* (*) Debugging vnet push / pop. */
 };
 
 struct mtx *thread_lock_block(struct thread *);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906111033.n5BAXV3x035759>