From owner-cvs-all Wed Sep 11 23:46: 6 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DAF637B400; Wed, 11 Sep 2002 23:46:00 -0700 (PDT) Received: from verifam.don.to (verifam.don.to [202.224.226.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EDD343E3B; Wed, 11 Sep 2002 23:45:59 -0700 (PDT) (envelope-from sumikawa@ebina.hitachi.co.jp) Received: from localhost (localhost [127.0.0.1]) by verifam.don.to (8.12.5/8.12.4) with ESMTP id g8C6l2JS028146; Thu, 12 Sep 2002 15:47:03 +0900 (JST) (envelope-from sumikawa@ebina.hitachi.co.jp) Date: Thu, 12 Sep 2002 15:44:52 +0900 (JST) Message-Id: <20020912.154452.47469593.sumikawa@ebina.hitachi.co.jp> To: brooks@one-eyed-alien.net Cc: sobomax@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, sumikawa@ebina.hitachi.co.jp Subject: Re: cvs commit: src/sys/net if_gif.c if_gif.h From: Munechika Sumikawa In-Reply-To: <20020905094452.A3044@Odin.AC.HMC.Edu> References: <200209051535.g85FZdq2038989@freefall.freebsd.org> <20020905094452.A3044@Odin.AC.HMC.Edu> X-Mailer: xcite1.43> Mew version 3.0.60 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Thu, Sep 05, 2002 at 08:35:39AM -0700, Maxim Sobolev wrote: > > sobomax 2002/09/05 08:35:39 PDT > > > > Modified files: > > sys/net if_gif.c if_gif.h > > Log: > > Make recursion prevention variable per-instance and remove XXX comment > > about thread-unsafety. > > Good solution. > > On minor issue. This changes the meaning of max_gif_nesting. Before it > was the number of gif over gif tunnels you could nest. Now it's > the number of times you can traverse the same tunnel while routing > a packet. I'm not sure it makes any sense for it to be tunable any more. 1. it's still thread unsafe when two different threads use same gif tunnel. 2. As Brooks said, when several tunnel are nested for example gif0 -> gif1 -> gif2 -> gif0, it's not counted rightly. --- Munechika SUMIKAWA @ KAME Project / FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message