From owner-cvs-all Sun Jan 6 19: 8:17 2002 Delivered-To: cvs-all@freebsd.org Received: from squall.waterspout.com (squall.waterspout.com [208.13.56.12]) by hub.freebsd.org (Postfix) with ESMTP id A8C2B37B41B; Sun, 6 Jan 2002 19:08:09 -0800 (PST) Received: by squall.waterspout.com (Postfix, from userid 1050) id 960D19B73; Sun, 6 Jan 2002 22:05:36 -0500 (EST) Date: Sun, 6 Jan 2002 22:05:36 -0500 From: Will Andrews To: "Jacques A. Vidrine" , Jeremy Lea Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/net/gnomeicu/files patch-src::icu_db.c Message-ID: <20020106220536.N73815@squall.waterspout.com> Reply-To: Will Andrews Mail-Followup-To: "Jacques A. Vidrine" , Jeremy Lea , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200201062053.g06KrMC19409@freefall.freebsd.org> <20020106213902.GA88137@madman.nectar.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020106213902.GA88137@madman.nectar.cc> User-Agent: Mutt/1.3.22.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jan 06, 2002 at 03:39:02PM -0600, Jacques A. Vidrine wrote: > #ifdef HAVE_STDLIB_H !? What language is this written in? > Please just s/malloc.h/stdlib.h/. Or if you must use a conditional, it > should look like > > #include > #ifdef HAVE_MALLOC_H > #include > #endif > > I think. It's possible that there is an OS that doesn't have stdlib.h. So autoconf in gnomeicu presumably does a check for it and defines HAVE_STDLIB_H if it exists. This is the correct fix, if reg@ wishes to get this merged into GnomeICU sources. Although I'd just take out #else #include personally. -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message