Date: Sun, 6 Jan 2002 22:05:36 -0500 From: Will Andrews <will@csociety.org> To: "Jacques A. Vidrine" <n@nectar.cc>, Jeremy Lea <reg@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/net/gnomeicu/files patch-src::icu_db.c Message-ID: <20020106220536.N73815@squall.waterspout.com> In-Reply-To: <20020106213902.GA88137@madman.nectar.cc> References: <200201062053.g06KrMC19409@freefall.freebsd.org> <20020106213902.GA88137@madman.nectar.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 06, 2002 at 03:39:02PM -0600, Jacques A. Vidrine wrote: > #ifdef HAVE_STDLIB_H !? What language is this written in? > Please just s/malloc.h/stdlib.h/. Or if you must use a conditional, it > should look like > > #include <stdlib.h> > #ifdef HAVE_MALLOC_H > #include <malloc.h> > #endif > > I think. It's possible that there is an OS that doesn't have stdlib.h. So autoconf in gnomeicu presumably does a check for it and defines HAVE_STDLIB_H if it exists. This is the correct fix, if reg@ wishes to get this merged into GnomeICU sources. Although I'd just take out #else #include <malloc.h> personally. -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020106220536.N73815>