From owner-cvs-all Fri Jun 7 9: 1:54 2002 Delivered-To: cvs-all@freebsd.org Received: from sdns.kv.ukrtel.net (sdns.kv.ukrtel.net [195.5.27.246]) by hub.freebsd.org (Postfix) with ESMTP id EB7D537B404; Fri, 7 Jun 2002 09:01:45 -0700 (PDT) Received: from vega.vega.com (195.5.51.243 [195.5.51.243]) by sdns.kv.ukrtel.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id M2L7D3DK; Fri, 7 Jun 2002 19:03:43 +0300 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g57G1n322803; Fri, 7 Jun 2002 19:01:49 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3D00D90A.9B67BDB0@FreeBSD.org> Date: Fri, 07 Jun 2002 19:02:18 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Doug Barton Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11/xscreensaver Makefile distinfo pkg-plistports/x11/xscreensaver/files patch-ab patch-driver::Makefile.inpatch-driver_Makefile.in References: <20020606134542.O4933-100000@master.gorean.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Doug Barton wrote: > > On Thu, 6 Jun 2002, Maxim Sobolev wrote: > > > Maxim Sobolev wrote: > > > > > > Please put PLIST_SUB for nognome case back, because otherwise PLIST is > > > broken. > > Please explain why that is true, since it works perfectly fine for me as > is. This is necessary when the GNOME is detected, but isn't explicitly turned on. Unfortunately our bsd.gnome.mk is broken in this sense, because it thinks that if gnome-config script is installed then all GNOME1 desktop should be pulled in (gnome-config script is part of gnomelibs), which screws up GNOME2. I've added an ugly workarond into xscreensaver to avoid this, but it needs this PLIST_SUB. In a nutshell, just trust me - it can't cause any problems, because it is only defined in the nognome case. > > > Attached is the patch which fixes this problem and another problem > > with PLIST (webcollage-helper) > > Please see my commit message as to why this isn't valid. One other thought > did occur to me though... is gdk-pixbuf always installed for gnome users? > If so, we could put webcollage-helper in under the PLIST_SUB for gnome > stuff. Yes, it does. Actually I do not see why you don't want to just include gdk-pixbuf into the LIB_DEPENDS - this library is very slim and doesn't have any dependencies apart from usual graphics libs and gtk+. This would resolve all problems. > > as well as fixes libintl detection and enables localisation of the > > frontend. Please either commit this patch or allow me commit it. > > I'll take a look at these bits and let you know, thanks. Any news on this? -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message