From owner-freebsd-arch@freebsd.org  Sun Oct  2 11:46:24 2016
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB101ADAC1F
 for <freebsd-arch@mailman.ysv.freebsd.org>;
 Sun,  2 Oct 2016 11:46:24 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5673DB9D;
 Sun,  2 Oct 2016 11:46:24 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u92BkEfY042193
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Sun, 2 Oct 2016 14:46:15 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u92BkEfY042193
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id u92BkDih042191;
 Sun, 2 Oct 2016 14:46:13 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 2 Oct 2016 14:46:13 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Jilles Tjoelker <jilles@stack.nl>
Cc: Lewis Donzis <lew@perftech.com>, deischen@freebsd.org,
 freebsd-arch@freebsd.org
Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11
Message-ID: <20161002114613.GE38409@kib.kiev.ua>
References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com>
 <20160930094544.GP38409@kib.kiev.ua>
 <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com>
 <20160930152006.GS38409@kib.kiev.ua> <20160930184418.1047afc2@kan>
 <20161001092515.GW38409@kib.kiev.ua>
 <20161001201655.GA91457@stack.nl>
 <20161001210722.GC38409@kib.kiev.ua>
 <20161001231524.GB91457@stack.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161001231524.GB91457@stack.nl>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Oct 2016 11:46:25 -0000

On Sun, Oct 02, 2016 at 01:15:24AM +0200, Jilles Tjoelker wrote:
> On Sun, Oct 02, 2016 at 12:07:22AM +0300, Konstantin Belousov wrote:
> > On Sat, Oct 01, 2016 at 10:16:55PM +0200, Jilles Tjoelker wrote:
> > > The idea is good, but perhaps call the function mq_getfd_np() to clarify
> > > it returns a file descriptor. Also, the __ versions should not be
> > > exported since they are not used outside the library (they can be
> > > exported if and when needed).
> 
> Please rename timer_oshandle_np() to timer_getfd_np() as well.
The timer handle is not an fd, so I kept the old name.  Using
_getfd there is IMO more confusing than the neutral _handle for
mq.

> 
> Looks ready to commit otherwise.
I do not think that we need to provide compat symbols.