From owner-cvs-all  Wed Jun 26 18:16:58 2002
Delivered-To: cvs-all@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id B96CB37D5B8; Wed, 26 Jun 2002 17:51:50 -0700 (PDT)
Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.12.4/8.12.3) with ESMTP id g5R0pgYB003530;
	Thu, 27 Jun 2002 04:51:47 +0400 (MSD)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: (from ache@localhost)
	by pobrecita.freebsd.ru (8.12.4/8.12.3/Submit) id g5R0pffa003529;
	Thu, 27 Jun 2002 04:51:41 +0400 (MSD)
	(envelope-from ache)
Date: Thu, 27 Jun 2002 04:51:40 +0400
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/crypto/openssh-portable session.c
Message-ID: <20020627005139.GA3331@nagual.pp.ru>
References: <200206261417.g5QEHTjR074759@freefall.freebsd.org> <20020626152357.GA30110@nagual.pp.ru> <xzpznxh1z2q.fsf@flood.ping.uio.no> <20020626221708.GA2178@nagual.pp.ru> <xzpfzz91xbk.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzpfzz91xbk.fsf@flood.ping.uio.no>
User-Agent: Mutt/1.5.1i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Jun 27, 2002 at 00:37:03 +0200, Dag-Erling Smorgrav wrote:
> "Andrey A. Chernov" <ache@nagual.pp.ru> writes:
> > BTW, it seems we have a bug in our login(1), login.c - new code does 
> > setenv(PATH...) _after_ setusercontext(), it means path= command in 
> > standard /etc/login.conf will not works.
> 
> man 3 setenv

Of course. I look too quick on code there and agree that PATH handling in 
login.c is right.

But, what happens with TERM in login.c?

(void)setenv("TERM", stypeof(tty), 0);
				  ^^^ not owervrite

I.e. it is not overwritted after setusercontext(). We definitely need an 
agreement here. Ether both login & sshd must overwrite TERM after 
setusercontext() or both do not. It seems that there is login.c bug in
the light of login.conf(5) "term" description.

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message