From owner-freebsd-net@FreeBSD.ORG Tue Oct 8 14:47:34 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E1BD9C46; Tue, 8 Oct 2013 14:47:34 +0000 (UTC) (envelope-from Eric_Van_Gyzen@dell.com) Received: from aussmtpmrkpc120.us.dell.com (aussmtpmrkpc120.us.dell.com [143.166.82.159]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 995FD2829; Tue, 8 Oct 2013 14:47:34 +0000 (UTC) X-Loopcount0: from 64.238.244.148 X-IronPort-AV: E=Sophos;i="4.90,1056,1371099600"; d="scan'208";a="47967551" Message-ID: <52541ABF.70101@dell.com> Date: Tue, 8 Oct 2013 09:46:23 -0500 From: Eric van Gyzen Organization: Dell, Inc. User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130702 Thunderbird/17.0.7 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: sys/net/radix.h: #define Free(p) for user-land References: <5252D7F7.3030709@dell.com> <20131008141504.GA22563@FreeBSD.org> In-Reply-To: <20131008141504.GA22563@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, Eric van Gyzen X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Oct 2013 14:47:35 -0000 On 10/08/2013 09:15, Gleb Smirnoff wrote: > On Mon, Oct 07, 2013 at 10:49:11AM -0500, Eric van Gyzen wrote: > E> The user-land definition of the Free() macro in sys/net/radix.h is > E> rather inconvenient. I work on a large C++ code-base, where several > E> classes define Free() functions. This header file gets indirectly > E> included in a few modules (via nested #includes), so we have to #undef > E> Free to work around this macro definition. > E> > E> Ideally, radix.h would define a more unique name, such as R_Free(). If > E> I were using a C code-base, you could say the same about my code, but > E> it's C++, and Free() is already well qualified by classes and/or namespaces. > E> > E> Is this Free() macro considered a well-defined, widely known, and > E> therefore mandatory part of the API, or could it be renamed to something > E> more unique? Alternatively, could it be changed to an inline function > E> definition, so as not to conflict with declarations in other > E> namespaces? If any of these is possible, I'll gladly provide the > E> blindingly trivial patch, although I don't have a commit bit. > E> > E> Finding in-tree consumers of this macro is difficult, due to its generic > E> name. Its counterparts--R_Malloc and R_Zalloc--only appear in > E> sys/net/{radix,route,rtsock}.c (on head). The recent ipfilter update > E> removed the only [potential] in-tree user-land consumer. > > The easiest way to find consumers would be to build test the trivial patch :) Gleb, So true. :) Before I bothered, I just wanted to ask if a change was impractical due to API commitments with several known out-of-tree consumers. Hearing no such replies, I'll test a patch. Eric