From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 19 00:20:24 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 987D916A4CF for ; Fri, 19 Dec 2003 00:20:24 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAEB343D55 for ; Fri, 19 Dec 2003 00:20:19 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) hBJ8KJFR089899 for ; Fri, 19 Dec 2003 00:20:19 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBJ8KJP6089898; Fri, 19 Dec 2003 00:20:19 -0800 (PST) (envelope-from gnats) Resent-Date: Fri, 19 Dec 2003 00:20:19 -0800 (PST) Resent-Message-Id: <200312190820.hBJ8KJP6089898@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oleg Sharoiko Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2C9816A4CE for ; Fri, 19 Dec 2003 00:14:52 -0800 (PST) Received: from brain.cc.rsu.ru (brain.cc.rsu.ru [195.208.252.154]) by mx1.FreeBSD.org (Postfix) with ESMTP id 695DC43D45 for ; Fri, 19 Dec 2003 00:14:49 -0800 (PST) (envelope-from os@brain.cc.rsu.ru) Received: from brain.cc.rsu.ru (localhost [127.0.0.1]) by brain.cc.rsu.ru (8.12.10/8.12.9) with ESMTP id hBJ8Dirx074132; Fri, 19 Dec 2003 11:13:44 +0300 (MSK) (envelope-from os@brain.cc.rsu.ru) Received: (from os@localhost) by brain.cc.rsu.ru (8.12.10/8.12.9/Submit) id hBJ8DiZr074131; Fri, 19 Dec 2003 11:13:44 +0300 (MSK) (envelope-from os) Message-Id: <200312190813.hBJ8DiZr074131@brain.cc.rsu.ru> Date: Fri, 19 Dec 2003 11:13:44 +0300 (MSK) From: Oleg Sharoiko To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: Andrey Beresovsky Subject: ports/60393: [PATCH] Makefile of security/cyrus-sasl2 is broken (both on -CURRENT and -STABLE) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Oleg Sharoiko List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Dec 2003 08:20:24 -0000 >Number: 60393 >Category: ports >Synopsis: [PATCH] Makefile of security/cyrus-sasl2 is broken (both on -CURRENT and -STABLE) >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Dec 19 00:20:19 PST 2003 >Closed-Date: >Last-Modified: >Originator: Oleg Sharoiko >Release: FreeBSD 5.2-BETA i386 >Organization: Computer Center of Rostov State University >Environment: System: FreeBSD brain.cc.rsu.ru 5.2-BETA FreeBSD 5.2-BETA #0: Tue Dec 2 13:24:13 MSK 2003 os@brain.cc.rsu.ru:/usr/obj/usr/src/sys/brain.athlon-xp.HEAD.2003-12-02 i386 >Description: The Makefile of security/cyrus-sasl2 is broken: make, /usr/ports/security/cyrus-sasl2 # make "Makefile", line 123: Malformed conditional (!defined(WITHOUT_GSSAPI) && (defined(MAKE_KERBEROS5) || ${OSVERSION} > 500105) && exists(/usr/lib/libkrb5.a)) make: fatal errors encountered -- cannot continue There seems to be two bugs: 1. Space is required after 500105 in order make don't treat it as a string "500105)" but as a number 500105 and a closing bracket 2. bsd.port.pre.mk should be included before the use of $OSVERSION >How-To-Repeat: cd /usr/ports/security/cyrus-sasl2 make >Fix: Apply the patch: --- Makefile Fri Dec 19 07:48:16 2003 +++ Makefile.fixed Fri Dec 19 10:36:49 2003 @@ -116,18 +116,18 @@ CONFIGURE_ARGS+=--enable-ntlm .endif +.include + .if !defined(WITHOUT_GSSAPI) && defined(KRB5_HOME) && exists(${KRB5_HOME}/lib/libgssapi_krb5.a) CONFIGURE_ARGS+=--enable-gssapi=${KRB5_HOME} .elif !defined(WITHOUT_GSSAPI) && defined(HEIMDAL_HOME) && exists(${HEIMDAL_HOME}/lib/libgssapi.a) CONFIGURE_ARGS+=--enable-gssapi=${HEIMDAL_HOME} --with-gss_impl=heimdal -.elif !defined(WITHOUT_GSSAPI) && (defined(MAKE_KERBEROS5) || ${OSVERSION} > 500105) && exists(/usr/lib/libkrb5.a) +.elif !defined(WITHOUT_GSSAPI) && (defined(MAKE_KERBEROS5) || ( ${OSVERSION} > 500105 )) && exists(/usr/lib/libkrb5.a) CONFIGURE_ARGS+=--enable-gssapi .else CONFIGURE_ARGS+=--disable-gssapi GSSAPI= "@comment " .endif - -.include # KERBEROS 4 was removed in FreeBSD 5.0-CURRENT .if ${OSVERSION} > 500105 >Release-Note: >Audit-Trail: >Unformatted: