From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:21:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E72116A46C for ; Mon, 20 Aug 2007 18:21:57 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.234]) by mx1.freebsd.org (Postfix) with ESMTP id CED9013C46E for ; Mon, 20 Aug 2007 18:21:56 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so924418wra for ; Mon, 20 Aug 2007 11:21:56 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=FrgwzzIYf9/KluhGUjYAQQjghx3B3uuiQJ+K6hp/Lf60+cPpNH5/85TC1T4rvs6GPDVaqrANVWAD8zIpaz+Qa+DM5U+9GZMV4JVLJJdeQJ89mzzsuli4iWpgN6OwVem5lbmf59my+2NNpSZtcIB42LMmyUgIdqocC40CCXAwcOM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k0OM4pCTIsE3B02TCA9Pfu/H1Sr8GeIJIC2ZqD9KYWahKuZXrRKLIuEPECP3KGuevUlnO1dpSG+x1n293tB2I190FlcyuA1Q2hcUn0G++SnnEN/+ge9i9ReoGYD1VTEm3Nej8A9gxuc5b+fK1LAKsGZM9xKTOuvWbmCaqDTh/5s= Received: by 10.90.34.3 with SMTP id h3mr10419957agh.1187632599192; Mon, 20 Aug 2007 10:56:39 -0700 (PDT) Received: by 10.100.122.7 with HTTP; Mon, 20 Aug 2007 10:56:39 -0700 (PDT) Message-ID: Date: Mon, 20 Aug 2007 10:56:39 -0700 From: "Matt Reimer" To: "Robert Watson" In-Reply-To: <20070819095302.D66918@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> X-Mailman-Approved-At: Mon, 20 Aug 2007 18:33:39 +0000 Cc: wine-freebsd@hub.org, Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:21:57 -0000 On 8/19/07, Robert Watson wrote: > > On Sat, 18 Aug 2007, Scott Long wrote: > > >> You can say that about a lot of APIs, but that doesn't mean we should add > >> them. This is a bit of a hack to satisfy one application (Wine) when there > >> are other (perhaps harder) ways to skin the cat. We certainly don't want > >> anything else using this API, so I'd advocate removing it. > > > > I'm in strong agreement here. David? > > This work was done by Tijl at the request of the PC-BSD guys, who would like > to be able to run windows applications out of the box on PC-BSD for their next > release (impending). David then reviewed and committed the patch giving it > his approval. The goal here was to avoid having the PC-BSD people have to run > around with additional system call patches for the forseeable future, and to > avoid requiring PC-BSD to fork the FreeBSD kernel to do that. In the meantime, how about implementing the syscall as a module that builds out of ports, using SYSCALL_MODULE() on the kernel side and modfind() on the userland side? That way the wine guys aren't blocked, but neither is code added to the kernel prematurely. Matt