From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Feb 19 17:50:47 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CAA2D18E for ; Thu, 19 Feb 2015 17:50:47 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9629B839 for ; Thu, 19 Feb 2015 17:50:47 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1JHolAq000345 for ; Thu, 19 Feb 2015 17:50:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197827] net-mgmt/xymon-client rc script does not handle "faststart" [patch] Date: Thu, 19 Feb 2015 17:50:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: john@jnielsen.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: feld@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 17:50:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197827 Bug ID: 197827 Summary: net-mgmt/xymon-client rc script does not handle "faststart" [patch] Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: feld@FreeBSD.org Reporter: john@jnielsen.net Assignee: feld@FreeBSD.org Flags: maintainer-feedback?(feld@FreeBSD.org) I'm not sure if it was an update to the port or -STABLE, but xymon-client no longer starts at boot on my system: % uname -a FreeBSD stealth.jnielsen.net 10.1-STABLE FreeBSD 10.1-STABLE #1 r278970M: Wed Feb 18 15:33:54 MST 2015 john@stealth.jnielsen.net:/ssdtmp/obj/usr/src/sys/STEALTH amd64 Feb 19 10:14:44 stealth kernel: Starting xymon_client. Feb 19 10:14:45 stealth kernel: Usage: /usr/local/www/xymon/client/runclient.sh start|stop|restart|status It also does not handle other prefixed commands (fast, force, one, quiet), since it includes "${1}" unsanitized in ${command_args}. I propose the following, to allow run_rc_command to do all of its magic and still pass the correct argument to runclient.sh. The patch works for me, but I am not the most experienced rc programmer. # diff -u xymon-client.orig xymon-client --- xymon-client.orig 2015-02-12 13:31:00.784342859 -0700 +++ xymon-client 2015-02-19 10:46:12.134221439 -0700 @@ -16,10 +16,10 @@ : ${xymon_client_enable:=NO} : ${xymon_client_user:=xymon} -command=/usr/local/www/xymon/client/runclient.sh -command_args="${xymon_client_flags} ${1}" procname=/usr/local/www/xymon/client/bin/xymonlaunch pidfile="/usr/local/www/xymon/client/logs/clientlaunch.`hostname`.pid" start_precmd="chown -R ${xymon_client_user} /usr/local/www/xymon/client/logs" +start_cmd="/usr/local/www/xymon/client/runclient.sh ${xymon_client_flags} start" +stop_cmd="/usr/local/www/xymon/client/runclient.sh ${xymon_client_flags} stop" run_rc_command "$1" --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer feld@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.