From owner-freebsd-scsi@FreeBSD.ORG  Tue Jul 10 17:02:06 2012
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 66B7E1065670;
	Tue, 10 Jul 2012 17:02:06 +0000 (UTC)
	(envelope-from seanbru@yahoo-inc.com)
Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com
	[98.139.253.104])
	by mx1.freebsd.org (Postfix) with ESMTP id 247208FC0A;
	Tue, 10 Jul 2012 17:02:06 +0000 (UTC)
Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231])
	by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id
	q6AH0sY6009755; Tue, 10 Jul 2012 10:00:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com;
	s=cobra; t=1341939656;
	bh=IR1KNwLcw7qQh7pNG8nj1Z8K91kGCAiTOvPm/jt+1Tc=;
	h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date:
	Message-ID:Mime-Version:Content-Transfer-Encoding;
	b=obunHMdu3YF3WFZH3r61fqmho8m1m8AzYhLFoSTgy801MPDLqoBVqltE3N0zgqI0M
	Eg8sOm6IRaLcJtw4Zer2UTlkg92A5eTPxB3+Z9kq4jPKP79EVCt1RMEP6qb7MxSLxo
	Aa9Xi3njCklY0F9/+ZD1UUW42aLT8mVQuOyjSFq4=
From: Sean Bruno <seanbru@yahoo-inc.com>
To: Andrew Boyer <aboyer@averesystems.com>
In-Reply-To: <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com>
References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com>
	<1341340916.3370.6.camel@powernoodle.corp.yahoo.com>
	<2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 10 Jul 2012 09:43:49 -0700
Message-ID: <1341938629.2573.7.camel@powernoodle.corp.yahoo.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 8bit
X-Milter-Version: master.31+4-gbc07cd5+
X-CLX-ID: 939655002
Cc: "freebsd-scsi@freebsd.org" <freebsd-scsi@freebsd.org>, scottl@freebsd.org,
	"ambrisko@FreeBSD.ORG" <ambrisko@freebsd.org>
Subject: Re: [patch] MFI should set bio_resid on command failure
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jul 2012 17:02:06 -0000

On Tue, 2012-07-10 at 09:37 -0700, Andrew Boyer wrote:
> On Jul 3, 2012, at 2:41 PM, Sean Bruno wrote:
> 
> > On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote:
> >> When an MFI command fails, the driver needs to set bio->bio_resid so that the upper levels notice.  Otherwise we see commands silently failing leading to data corruption.  This mirrors dadone().
> >> 
> >> -Andrew
> >> 
> >> Index: sys/dev/mfi/mfi_disk.c
> >> ===================================================================
> >> --- sys/dev/mfi/mfi_disk.c	(revision 238071)
> >> +++ sys/dev/mfi/mfi_disk.c	(working copy)
> >> @@ -298,6 +298,7 @@
> >> 	hdr = bio->bio_driver1;
> >> 
> >> 	if (bio->bio_flags & BIO_ERROR) {
> >> +		bio->bio_resid = bio->bio_bcount;
> >> 		if (bio->bio_error == 0)
> >> 			bio->bio_error = EIO;
> >> 		disk_err(bio, "hard error", -1, 1);
> >> 
> >> --------------------------------------------------
> >> Andrew Boyer	aboyer@averesystems.com
> >> 
> > 
> > This looks right to me.  It mirrors the behavior in mfi_disk_strategy()
> > as well.
> > 
> > Sean
> > 
> 
> Anyone interested in committing?  (And MFC'ing to stable/8…)
> 
> -Andrew
> 
> --------------------------------------------------
> Andrew Boyer	aboyer@averesystems.com
> 
> 
> 

Let me hit dougA and scottl for validation.  Their wisdom here can
validate my naivete.

Sean