From owner-svn-src-head@FreeBSD.ORG Sat Dec 21 16:45:18 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26257FA5; Sat, 21 Dec 2013 16:45:18 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DA1421152; Sat, 21 Dec 2013 16:45:17 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.15]) by ltcfislmsgpa07.fnfis.com (8.14.5/8.14.5) with ESMTP id rBLGjGZP010314 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 21 Dec 2013 10:45:16 -0600 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.7]) by LTCFISWMSGHT04.FNFIS.com ([10.132.206.15]) with mapi id 14.03.0158.001; Sat, 21 Dec 2013 10:45:15 -0600 From: "Teske, Devin" To: Nathan Whitehorn Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts Thread-Topic: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts Thread-Index: AQHO/mbdkcgFyHyrTEqBVO9KeR/sVQ== Date: Sat, 21 Dec 2013 16:45:14 +0000 Message-ID: <3D3536A7-B671-4170-99D0-B5C876BDEEAF@fisglobal.com> References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org> <52B5AA94.3060009@freebsd.org> <52B5BDD1.3000106@freebsd.org> <37E2A444-38C0-4E8C-A2E1-5FA23B9B0FFF@fisglobal.com> <52B5C279.4020103@freebsd.org> In-Reply-To: <52B5C279.4020103@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.120] Content-Type: text/plain; charset="us-ascii" Content-ID: <1FB00AF9F40C0B489216B98A539BB101@fisglobal.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.87, 1.0.14, 0.0.0000 definitions=2013-12-21_01:2013-12-20,2013-12-21,1970-01-01 signatures=0 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Devin Teske , "src-committers@freebsd.org" , "Teske, Devin" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Devin Teske List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 16:45:18 -0000 On Dec 21, 2013, at 8:31 AM, Nathan Whitehorn wrote: > On 12/21/13 10:25, Teske, Devin wrote: >> On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: >>=20 >>> Looks great, thanks -- although you don't need the f_quietly, which >>> isn't defined there. >>>=20 >>> The issue is that this patch very specific to running the installer on a >>> video console. There are many circumstances in which it is not, in which >>> case this will fail (e.g. a serial console). The other thing is that the >>> installer should not reconfigure the host system unless it has been >>> explicitly asked to. It isn't always run from the install media. If you >>> think the default bindings for these keys don't make sense, then that >>> should ultimately be fixed in the console driver as well. >> My inspiration for this change came from a tweet in which we were >> (unjustly or not; doesn't matter) slammed for not having addressed >> this issue since it (as the person claims) first appeared in 6.x. >>=20 >> Having felt the persons pain (and verified that, indeed, we continue >> to be plagued in 10) I decided to do start researching the problem >> in-depth. >>=20 >> The links I posted in the commit message give an excellent view of >> the issue and in-fact doesn't even mention using kbdcontrol. Instead >> it is suggested that we create an alternate keymap that ignores the >> command keys. >>=20 >> That sounds like one approach (and wins points because it is opt- >> in) but it doesn't solve the problem for me or anyone else running >> the installer. >>=20 >> Perhaps if we had this alternate keymap in the base which does the >> desired thing (ignore the command keys), then we could just say that >> the user ought to select said keymap at the onset of the installation >> process. >>=20 >> But I'm not sure *I* like that approach because then it means that for >> my own testing, I have to select an alternate keymap everytime I run >> the installer in VMware. >>=20 >> Rather, it seems to me that the installation process, if it ignored the >> command key on every non-serial platform... this would be fine. >> Afterall, once they get the system installed, they'll have the desired >> keymap set and they can forget. >=20 > I'd prefer opt-out -- having the default be the option that is least > surprising is a good idea. In any case, moving it to rc.local solves all > the immediate problem. We can think about changing keymaps for the base later; for now, I've moved the kbdcontrol invocations to the new spot (SVN r259686). Much better if I do say so myself; much thanks for the suggested new location. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.