From owner-cvs-ports@FreeBSD.ORG  Mon Apr 16 01:09:55 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7161F106566B;
	Mon, 16 Apr 2012 01:09:55 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
	by mx1.freebsd.org (Postfix) with ESMTP id 45E678FC08;
	Mon, 16 Apr 2012 01:09:55 +0000 (UTC)
Received: from L48.suse.de (charybdis-ext.suse.de [195.135.221.2])
	by ainaz.pair.com (Postfix) with ESMTPSA id 856503F446;
	Sun, 15 Apr 2012 21:09:48 -0400 (EDT)
Date: Mon, 16 Apr 2012 03:09:36 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Michael Scheidell <scheidell@FreeBSD.org>
In-Reply-To: <4F8AB5C1.9030405@FreeBSD.org>
Message-ID: <alpine.LNX.2.00.1204160306180.2457@gerinyyl.fvgr>
References: <201204142151.q3ELpGFS087738@repoman.freebsd.org>
	<20120415132903.10f75d1f@FreeBSD.org>
	<4F8AB5C1.9030405@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Pawel Pekala <pawel@FreeBSD.org>
Subject: Re: cvs commit: ports/deskutils/cairo-dock-plugins Makefile distinfo
 ports/deskutils/cairo-dock-plugins/files patch-CDBashApplet.sh
 patch-Doncky-data-nvidia-config         patch-GMenu-applet-menu
 patch-Network-Monitor-data-access-point patch-Network-Monitor-data-wifi   
 patch-System-Monitor-data-nvidia-config patch-System-Monitor.conf.in
 patch-applet-appli-finder.c ...
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 01:09:55 -0000

On Sun, 15 Apr 2012, Michael Scheidell wrote:
>> This will break when LOCALBASE != /usr/local and it's user-settable
>> variable as documented in ports(7). And two small questions:
>> - could some of this be better solved by using REINPLACE_CMD ?
>> - there's a lot bash scripts, shouldn't be there RUN_DEPENDS+= bash ?
> let me ping the previous committer gerald@ and see if he had any 
> discussions on this. his commit was about 7 days ago, and I have 
> searched the archives and don't see that any similar discussions took 
> place last week.

Yes, I did suggest to the maintainer that he approaches upstream to
find a better solution rather than hardcoding those paths in several
places.  That update of his was a clear improvement, however, so I
did commit it without waiting for perfection.

> I will also ping (without cvs-* and private groups) maintainer 
> fidaj@ukr.net (I am sure he would welcome patches and a pr.. he
> seems to be very active with updates to this port)

I found him very responsive and helpful and a pleasure to work with.
So whatever further notes you guys have, let him know and I am sure
he will try to honor them.

Gerald