Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Oct 2006 10:01:02 GMT
From:      Roman Divacky <rdivacky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 107870 for review
Message-ID:  <200610141001.k9EA123a065280@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107870

Change 107870 by rdivacky@rdivacky_witten on 2006/10/14 10:00:56

	Use LINUX_SIG_VALID through the code.

Affected files ...

.. //depot/projects/linuxolator/src/sys/amd64/linux32/linux32_machdep.c#11 edit
.. //depot/projects/linuxolator/src/sys/compat/linux/linux_signal.c#2 edit
.. //depot/projects/linuxolator/src/sys/i386/linux/linux_machdep.c#6 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/amd64/linux32/linux32_machdep.c#11 (text+ko) ====

@@ -539,7 +539,7 @@
 #endif
 
 	exit_signal = args->flags & 0x000000ff;
-	if (exit_signal >= LINUX_NSIG)
+	if (!LINUX_SIG_VALID(exit_signal))
 		return (EINVAL);
 
 	if (exit_signal <= LINUX_SIGTBLSZ)

==== //depot/projects/linuxolator/src/sys/compat/linux/linux_signal.c#2 (text+ko) ====

@@ -144,7 +144,7 @@
 	struct sigaction act, oact, *nsa, *osa;
 	int error, sig;
 
-	if (linux_sig <= 0 || linux_sig > LINUX_NSIG)
+	if (!LINUX_SIG_VALID(linux_sig))
 		return (EINVAL);
 
 	osa = (linux_osa != NULL) ? &oact : NULL;
@@ -438,7 +438,7 @@
 	/*
 	 * Allow signal 0 as a means to check for privileges
 	 */
-	if (args->signum < 0 || args->signum > LINUX_NSIG)
+	if (!LINUX_SIG_VALID(args->signum) && args->signum != 0)
 		return EINVAL;
 
 	if (args->signum > 0 && args->signum <= LINUX_SIGTBLSZ)

==== //depot/projects/linuxolator/src/sys/i386/linux/linux_machdep.c#6 (text+ko) ====

@@ -365,7 +365,7 @@
 #endif
 
 	exit_signal = args->flags & 0x000000ff;
-	if (exit_signal >= LINUX_NSIG)
+	if (!LINUX_SIG_VALID(exit_signal))
 		return (EINVAL);
 
 	if (exit_signal <= LINUX_SIGTBLSZ)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610141001.k9EA123a065280>