From owner-cvs-ports  Fri Nov  8 08:10:46 1996
Return-Path: owner-cvs-ports
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id IAA18571
          for cvs-ports-outgoing; Fri, 8 Nov 1996 08:10:46 -0800 (PST)
Received: from cabri.obs-besancon.fr (cabri.obs-besancon.fr [193.52.184.3])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id IAA18539;
          Fri, 8 Nov 1996 08:10:21 -0800 (PST)
Received: by cabri.obs-besancon.fr (5.57/Ultrix3.0-C)
	id AA07878; Fri, 8 Nov 96 17:12:16 +0100
Date: Fri, 8 Nov 96 17:12:16 +0100
Message-Id: <9611081612.AA07878@cabri.obs-besancon.fr>
From: Jean-Marc Zucconi <jmz@cabri.obs-besancon.fr>
To: asami@freebsd.org
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-ports@freefall.freebsd.org
In-Reply-To: <199611080313.TAA01349@silvia.HIP.Berkeley.EDU>
	(asami@freebsd.org)
Subject: Re: cvs commit:  ports/x11/XFree86 Makefile ports/x11/XFree86/files md5 ports/x11/XFree86/pkg COMMENT DESCR PLIST ports/x11/XFree86/scripts configure
X-Mailer: Emacs
Sender: owner-cvs-ports@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>>>>> Satoshi Asami writes:

 >  *  > Thanks, but I think you forgot to cvs add Makefile.ftp.
 >  * 
 >  * Done.

 > Thanks...but is this file really necessary?  There is nothing in there 
 > that can't be in the regular Makefile.

 > Actually, looking at the Makefile, I get the impression that it is
 > unnecessarily complex and non-standard, probably because of the
 > history from back when you had support for FTP and two different
 > CDROMs.

Yes, and I did not want to remove Makefile.ftp because there were
problems with cvs when we needed to resurect deleted files. I just
discovered that this is no more the case with the current version of
cvs, so lets merge the Makefiles.

 > I made it much simpler, it seems to work fine.

Commit it please. But are you sure that the PREFIX macro is not required?
I added it to make 'make package' to work. 


 >  * What is the problem with "./" ? With such a PLIST you are sure to
 >  * never forgot a file. The restriction is that you are forced to make an
 >  * install in an empty /usr/X11R6 directory if you want to make a
 >  * package, but this is not a problem. 

 > I'm not worried about the package itself, it's pkg_delete.  The user
 > should be able to "pkg_delete XFree86-3.1.2" and then install the new
 > version to safely upgrade the system.  Also we will lose the ability
 > to grep the PLIST or +CONTENTS to see where the file came from.

 >  * 				       Of course, removing the package
 >  * implies that everything under X11R6 will be removed, but this is
 >  * logical since all other ports depend on X11 :-)

 > I'm assuming this is a joke, right?  (Yes, I see the smiley, sorry to
 > be so dense but someone might believe it. ;)

 >  * On the other hand the PLIST depends on the options you choose at
 >  * configure time.

 > Just list everything, I assume it's mostly the X servers, right?  The
 > only problem is a warning at pkg_delete.

The X servers, XF86Setup (can't be built because there is a problem
with /usr/lib/libtcl75) and maybe some fonts.

 > If it's too much trouble for you, I can make the PLIST (I just did a
 > full build myself and still have the tree around, I only need to do a
 > find to make the list and add the servers I didn't build).

Yes please but test the 'make package' command also :-)

 > Satoshi

Jean-Marc
 _____________________________________________________________________________
 Jean-Marc Zucconi       Observatoire de Besancon       F 25010 Besancon cedex
                   PGP Key: finger jmz@cabri.obs-besancon.fr
 =============================================================================