From owner-p4-projects  Wed Jul 31 14:57:58 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3924B37B401; Wed, 31 Jul 2002 14:57:53 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A307F37B400; Wed, 31 Jul 2002 14:57:52 -0700 (PDT)
Received: from holly.calldei.com (adsl-208-191-149-232.dsl.hstntx.swbell.net [208.191.149.232])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 325CE43E31; Wed, 31 Jul 2002 14:57:52 -0700 (PDT)
	(envelope-from chris@holly.dyndns.org)
Received: by holly.calldei.com (Postfix, from userid 1001)
	id CBA4AB00; Wed, 31 Jul 2002 16:58:45 -0500 (CDT)
Date: Wed, 31 Jul 2002 16:58:45 -0500
From: Chris Costello <chris@FreeBSD.org>
To: Brian Feldman <green@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 15347 for review
Message-ID: <20020731215844.GD7042@holly.calldei.com>
Reply-To: chris@FreeBSD.org
References: <200207312131.g6VLVV8L053036@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200207312131.g6VLVV8L053036@freefall.freebsd.org>
User-Agent: Mutt/1.4i
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

On Wednesday, July 31, 2002, Brian Feldman wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=15347
> 
> Change 15347 by green@green_laptop_2 on 2002/07/31 14:31:24
> 
> 	mac_cred_canexec() no longer exists; use mac_check_vnode_exec().

   You misspelled "Unlock `p' when locking the vnode to
transition the credential" or something like that...

> Affected files ...
> 
> .. //depot/projects/trustedbsd/mac/sys/kern/kern_exec.c#28 edit
> 
> Differences ...
> 
>  #ifdef MAC
> +	PROC_UNLOCK(p);
>  	vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY, td);
>  	will_transition = mac_execve_will_transition(oldcred, imgp->vp);
>  	credential_changing |= will_transition;
>  	VOP_UNLOCK(imgp->vp, 0, td);
> +	PROC_LOCK(p);
>  #endif
>  
>  	if (credential_changing &&
> @@ -438,11 +440,13 @@
>  			change_egid(newcred, attr.va_gid);
>  #ifdef MAC
>  		if (will_transition) {
> +			PROC_UNLOCK(p);
>  			vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY, td);
>  			mac_execve_transition(oldcred, newcred, imgp->vp);
>  			VOP_UNLOCK(imgp->vp, 0, td);
> +			PROC_LOCK(p);
>  		}
> -#endif
> +#endif /* MAC */

-- 
Chris Costello                                <chris@FreeBSD.org>
FreeBSD Project                           http://www.FreeBSD.org/
TrustedBSD Project                     http://www.TrustedBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message