From owner-freebsd-current Fri Oct 4 16: 3:34 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AE2737B401 for ; Fri, 4 Oct 2002 16:03:32 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05BCF43E6E for ; Fri, 4 Oct 2002 16:03:28 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 4DA262A896; Fri, 4 Oct 2002 16:03:24 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Terry Lambert Cc: Emiel Kollof , Poul-Henning Kamp , n0go013 , current Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost In-Reply-To: <3D9E0DD8.1C9526DE@mindspring.com> Date: Fri, 04 Oct 2002 16:03:24 -0700 From: Peter Wemm Message-Id: <20021004230324.4DA262A896@canning.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Terry Lambert wrote: > Emiel Kollof wrote: > > * Peter Wemm (peter@wemm.org) wrote: > > > vinum is so much unbelievable stuff in it. Consider this stuff: > > > > > > sys/dev/vinum/vinumio.c: > > [ ... ] > > > > This crud has *got* to be taken out and shot, then reworked to do it > > > properly. > > > > Amen! (and no, I'm not volunteering. I don't mind cleaning up code, but the re > > are limits to what crud I touch) > > > FWIW: > > The comment right before that code is: > > /* > * Yes, Bruce, I know this is horrible, but we > * don't have a root file system when we first > * try to do this. If you can come up with a > * better solution, I'd really like it. I'm > * just putting it in now to add ammuntion to > * moving the system to devfs. > */ > > ...basically, when devfs became default, the person who made it > default did not maintain this code, when they converted everything > else over to using it. > > The assumption here is that the devfs will be available to the > system before the root is mounted transparently over it. Actually no, this is only used *after* root is mounted. > This is > also doable with an unmounted instance of the backing devfs, not > yet mounted on /dev, if a transparent mount of / over top of a > preexiting / -> /dev is not supported (i.e. devfs is mounted on > /dev on the root FS, rather than the root FS being mounted on a > backing node on which defvfs is already mounted on /, and the > devices showing through as if they were on /). > > I think the major problem with the Vinum code is that it isn't > very readable in an 80 column editor window with 8 column tabs, > but that's pretty much the worst you can say about it, other than > the code has not been maintained by the people changing subsystems > out from under it. > > Another alternative is to disable support for mounting vinum > plexes as the root filesystem, which is what this code supposedly > supports. Nope. Vinum doesn't support booting with a plex as a root file system. I can't quite say that I understand what this is for though. namei() etc are perfectly usable at this point. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message