From owner-cvs-all  Sat Dec 21 15:10:49 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C687D37B401; Sat, 21 Dec 2002 15:10:47 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A406943EE5; Sat, 21 Dec 2002 15:10:46 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id KAA22485;
	Sun, 22 Dec 2002 10:10:41 +1100
Date: Sun, 22 Dec 2002 10:12:28 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Matthew Dillon <dillon@apollo.backplane.com>
Cc: cvs-committers@FreeBSD.ORG, <cvs-all@FreeBSD.ORG>
Subject: Re: cvs commit: src/sys/dev/usb umass.c
In-Reply-To: <200212202357.gBKNvGno024098@apollo.backplane.com>
Message-ID: <20021222095435.O7325-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, 20 Dec 2002, Matthew Dillon wrote:

> :On Fri, 20 Dec 2002, Matt Dillon wrote:
> :
> :> dillon      2002/12/20 10:56:55 PST
> :>
> :>   Modified files:
> :>     sys/dev/usb          umass.c
> :>   Log:
> :>   Modify the fake cylinders calculation so it is >= the size of the device,
> :>   not < the size of the device.  This avoids geom complaints.
> :
> :This was just another bug in geom.  ccg->cylinders always gave the number of
> :full cylinders.
> :
> :Bruce
>
>     I can back that out, but has it been fixed in geom yet?  I don't want
>     to back it out (and re-break usb umass storage) until its fixed in
>     geom.

I don't use geom, and try not to look at it :-).  I can't find where it
complains actually.

Most places, shouldn't care, but libdisk/disk.c rev.1.102 wanted the size
to be an exact multiple of the number of cylinders.  This was fixed in
rev.1.109, so apparently disks that don't satisfy this occur in nature
for more than umass.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message